From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: pmeerw@pmeerw.net, srinivas.pandruvada@linux.intel.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: accel: kxcjk-1013: Fix defined but unused warning
Date: Sun, 14 Sep 2014 18:34:22 +0100 [thread overview]
Message-ID: <5415D19E.9030105@kernel.org> (raw)
In-Reply-To: <1409757192-17546-1-git-send-email-daniel.baluta@intel.com>
On 03/09/14 16:13, Daniel Baluta wrote:
> Noticed when compiling with CONFIG_PM_RUNTIME not set:
> kxcjk-1013.c: warning: ‘kxcjk1013_get_startup_times’ defined but not used [-Wunused-function]
>
> Introduced by commit 124e1b1d (iio: accel: kxcjk-1013: support runtime pm).
>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Note, convention is author first in this list then reviewers etc then sign offs from
those handling the patch.
Applied to the togreg branch of iio.git - initially pushed out as testing.
Thanks,
J
> ---
> drivers/iio/accel/kxcjk-1013.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 736231d..eb1b8b6 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -307,6 +307,7 @@ static int kxcjk1013_chip_init(struct kxcjk1013_data *data)
> return 0;
> }
>
> +#ifdef CONFIG_PM_RUNTIME
> static int kxcjk1013_get_startup_times(struct kxcjk1013_data *data)
> {
> int i;
> @@ -318,6 +319,7 @@ static int kxcjk1013_get_startup_times(struct kxcjk1013_data *data)
>
> return KXCJK1013_MAX_STARTUP_TIME_US;
> }
> +#endif
>
> static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on)
> {
>
prev parent reply other threads:[~2014-09-14 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 15:13 [PATCH] iio: accel: kxcjk-1013: Fix defined but unused warning Daniel Baluta
2014-09-14 17:34 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5415D19E.9030105@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.