Re: [PATCH v2 09/11] iio:bma180: Prepare for accelerometer channels with different resolutions

[Jonathan Cameron <jic23@kernel.org>]

On 19/08/14 23:43, Peter Meerwald wrote:
> allow to specify channels resolution and compute shift assuming
> 16-bit registers and MSB allocation
> 
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
Applied
> ---
>  drivers/iio/accel/bma180.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> index a25b060..6e940b0 100644
> --- a/drivers/iio/accel/bma180.c
> +++ b/drivers/iio/accel/bma180.c
> @@ -474,7 +474,7 @@ static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
>  	{ },
>  };
>  
> -#define BMA180_ACC_CHANNEL(_axis) {					\
> +#define BMA180_ACC_CHANNEL(_axis, _bits) {				\
>  	.type = IIO_ACCEL,						\
>  	.modified = 1,							\
>  	.channel2 = IIO_MOD_##_axis,					\
> @@ -484,9 +484,9 @@ static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
>  	.scan_index = AXIS_##_axis,					\
>  	.scan_type = {							\
>  		.sign = 's',						\
> -		.realbits = 14,						\
> +		.realbits = _bits,					\
>  		.storagebits = 16,					\
> -		.shift = 2,						\
> +		.shift = 16 - _bits,					\
>  	},								\
>  	.ext_info = bma180_ext_info,					\
>  }
> @@ -504,9 +504,9 @@ static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
>  }
>  
>  static const struct iio_chan_spec bma180_channels[] = {
> -	BMA180_ACC_CHANNEL(X),
> -	BMA180_ACC_CHANNEL(Y),
> -	BMA180_ACC_CHANNEL(Z),
> +	BMA180_ACC_CHANNEL(X, 14),
> +	BMA180_ACC_CHANNEL(Y, 14),
> +	BMA180_ACC_CHANNEL(Z, 14),
>  	BMA180_TEMP_CHANNEL,
>  	IIO_CHAN_SOFT_TIMESTAMP(4),
>  };
>