From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35024)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guz.fnst@cn.fujitsu.com>) id 1XTQAH-0000on-Ub
	for qemu-devel@nongnu.org; Mon, 15 Sep 2014 02:53:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <guz.fnst@cn.fujitsu.com>) id 1XTQAD-0002u6-0d
	for qemu-devel@nongnu.org; Mon, 15 Sep 2014 02:53:33 -0400
Received: from [59.151.112.132] (port=12848 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guz.fnst@cn.fujitsu.com>) id 1XTQAC-0002tc-Kw
	for qemu-devel@nongnu.org; Mon, 15 Sep 2014 02:53:28 -0400
Message-ID: <541689AF.8010205@cn.fujitsu.com>
Date: Mon, 15 Sep 2014 14:39:43 +0800
From: Gu Zheng <guz.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1409197002-9498-1-git-send-email-guz.fnst@cn.fujitsu.com>
	<1409197002-9498-11-git-send-email-guz.fnst@cn.fujitsu.com>
	<CAGZKiBpO3oxijjXrdzdxo4n+dDmnQp7UP=hd7k4W03Xg_G85-A@mail.gmail.com>
	<54117105.8000007@cn.fujitsu.com>
	<CAGZKiBp8dDNyb4KTGD_K4nS_cp9fntUMSCLkqReCnRmujmvriw@mail.gmail.com>
	<54124B47.2050504@cn.fujitsu.com>
	<CAGZKiBoL7W2BXnOk5uGP4B_DpkzvA9vVftNzaMwSXrwFvMJfag@mail.gmail.com>
	<5412C2B6.4020603@cn.fujitsu.com>
	<CAM4NYE9Z2dPRzENyc76q8tWgp-JvM+bq1MfSS6NSqnrPeaa6yQ@mail.gmail.com>
	<CAGZKiBqBd4K9z5QJ37_iw=OwPj_VfMEf9E_47_2pFayi=PG1FQ@mail.gmail.com>
In-Reply-To: <CAGZKiBqBd4K9z5QJ37_iw=OwPj_VfMEf9E_47_2pFayi=PG1FQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bharata B Rao <bharata.rao@gmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Igor Mammedov <imammedo@redhat.com>, ChenFan <chen.fan.fnst@cn.fujitsu.com>, Anshul Makkar <anshul.makkar@profitbricks.com>, "afaerber@suse.de" <afaerber@suse.de>

Hi Bharata,
On 09/12/2014 09:52 PM, Bharata B Rao wrote:

> On Fri, Sep 12, 2014 at 4:23 PM, Anshul Makkar
> <anshul.makkar@profitbricks.com> wrote:
>> During plugging we can see this event: echo 1 > cpu8/online.
>>
>> But during unplugging , we can't see the event echo 0 > cpu8/online.
> 
> That's because I didn't do that explicitly, was always trying to
> remove an online cpu from the monitor w/o explicitly offlining it from
> inside the guest. Either ways I still see the removed CPU being listed
> in QEMU monitor.
> 
> I don't ever hit any of the below code paths during CPU removal:

It seems that the guest OS did not call the "_EJ0" method.
Could you please dump the guest os' acpi dsdt, and check whether the "_EJ0"
method exists? 

> 
> cpus.c: qemu_kvm_destroy_vcpu()
> cpus.c: x86_cpu_finalizefn()
> 
> I see CPU_REMOVE() being called from above two routines.
> 
> And neither does hw/acpi/cpu_hotplug.c:cpu_status_write() gets called
> here. Does the message "ACPI: Device does not support D3cold" guest
> kernel throws during hot removal is causing this behaviour here ?
> Guest kernel is 3.11.10, should I be on latest kernel ?

I have tested the fedora 20 guest with the default kernel, it works well,
so the kernel should be fine.
One more question, is the guest kernel config the same as fedora 20's default one?

Thanks,
Gu

> 
> Regards,
> Bharata.
> .
>