Re: [PATCH v4] ARM: dts: exynos3250: add MFC codec device node

[Jacek Anaszewski <j.anaszewski@samsung.com>]

Hi Kukjin,

On 09/13/2014 07:08 PM, Kukjin Kim wrote:
> On 09/09/14 22:09, Jacek Anaszewski wrote:
>> Signed-off-by: Jacek Anaszewski<j.anaszewski@samsung.com>
>> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>> Cc: Kukjin Kim<kgene.kim@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos3250.dtsi |   12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
>> b/arch/arm/boot/dts/exynos3250.dtsi
>> index bbc1e4c..95cc5a1 100644
>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>> @@ -294,6 +294,18 @@
>>               status = "disabled";
>>           };
>>
>> +        mfc-codec@13400000 {
>
> mfc: codec@13400000 {
>
>> +            compatible = "samsung,mfc-v7";
>> +            reg =<0x13400000 0x10000>;
>> +            interrupts =<0 102 0>;
>> +            clock-names = "mfc", "sclk_mfc";
>> +            clocks =<&cmu CLK_MFC>,<&cmu CLK_SCLK_MFC>;
>> +            #address-cells =<1>;
>> +            #size-cells =<0>;
>
> are the address-cells and size-cells required here?

They are not. I overlooked this.

>> +            samsung,power-domain =<&pd_mfc>;
>> +            status = "disabled";
>> +        };
>> +
>>           serial_0: serial@13800000 {
>>               compatible = "samsung,exynos4210-uart";
>>               reg =<0x13800000 0x100>;
>
> - Kukjin
>

Best Regards,
Jacek Anaszewski