Re: [Patch net-next v2] net_sched: fix memory leak in cls_tcindex

[John Fastabend <john.fastabend@gmail.com>]

On 09/15/2014 04:43 PM, Cong Wang wrote:
> Fixes: commit 331b72922c5f58d48fd ("net: sched: RCU cls_tcindex")
> Cc: John Fastabend <john.fastabend@gmail.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
>
> v2: fix err = -ENOMEM
>
>   net/sched/cls_tcindex.c | 17 ++++++++++-------
>   1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c
> index dd2d691..ee52542 100644
> --- a/net/sched/cls_tcindex.c
> +++ b/net/sched/cls_tcindex.c
> @@ -242,8 +242,10 @@ tcindex_set_parms(struct net *net, struct tcf_proto *tp, unsigned long base,
>   	 * perfect hash and hash pointers from old data.
>   	 */
>   	cp = kzalloc(sizeof(*cp), GFP_KERNEL);
> -	if (!cp)
> -		return -ENOMEM;
> +	if (!cp) {
> +		err = -ENOMEM;
> +		goto errout;
> +	}

Thanks for fixing up tcindex for me I see now it was missing
from my test scripts. Along with cls_bpf so I'll need to go
back and test that as well.

Acked-By: John Fastabend <john.r.fastabend@gmail.com>


-- 
John Fastabend         Intel Corporation