From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gu Zheng Subject: Re: [PATCH 4/5] f2fs: fix to clean previous mount option when remount_fs Date: Tue, 16 Sep 2014 09:50:32 +0800 Message-ID: <54179768.2010708@cn.fujitsu.com> References: <003001cfd0cc$96f9e8e0$c4edbaa0$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XTi7s-0003tZ-1M for linux-f2fs-devel@lists.sourceforge.net; Tue, 16 Sep 2014 02:04:16 +0000 Received: from [59.151.112.132] (helo=heian.cn.fujitsu.com) by sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1XTi7q-00079B-Ri for linux-f2fs-devel@lists.sourceforge.net; Tue, 16 Sep 2014 02:04:15 +0000 In-Reply-To: <003001cfd0cc$96f9e8e0$c4edbaa0$@samsung.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Chao Yu Cc: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Hi Yu, On 09/15/2014 06:04 PM, Chao Yu wrote: > In manual of mount, we descript remount as below: > > "mount -o remount,rw /dev/foo /dir > After this call all old mount options are replaced and arbitrary stuff from > fstab is ignored, except the loop= option which is internally generated and > maintained by the mount command." > > Previously f2fs do not clear up old mount options when remount_fs, so we have no > chance of disabling previous option (e.g. flush_merge). Fix it. Please don't. "Remount" should just change what you specified and keep others unchanged. The problem here is that we need to provide mount opts for disable/enable some features, but we missed it. So the right way is adding these opts if we really need them. Thanks, Gu > > Signed-off-by: Chao Yu > --- > fs/f2fs/super.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 54444bb..90fcbe0 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -616,6 +616,9 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) > org_mount_opt = sbi->mount_opt; > active_logs = sbi->active_logs; > > + sbi->mount_opt.opt = 0; > + sbi->active_logs = NR_CURSEG_TYPE; > + > /* parse mount options */ > err = parse_options(sb, data); > if (err) ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce. Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755706AbaIPCEL (ORCPT ); Mon, 15 Sep 2014 22:04:11 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:12007 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752867AbaIPCEJ (ORCPT ); Mon, 15 Sep 2014 22:04:09 -0400 X-IronPort-AV: E=Sophos;i="5.04,532,1406563200"; d="scan'208";a="35999736" Message-ID: <54179768.2010708@cn.fujitsu.com> Date: Tue, 16 Sep 2014 09:50:32 +0800 From: Gu Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Chao Yu CC: Jaegeuk Kim , Changman Lee , , Subject: Re: [f2fs-dev][PATCH 4/5] f2fs: fix to clean previous mount option when remount_fs References: <003001cfd0cc$96f9e8e0$c4edbaa0$@samsung.com> In-Reply-To: <003001cfd0cc$96f9e8e0$c4edbaa0$@samsung.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.100] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yu, On 09/15/2014 06:04 PM, Chao Yu wrote: > In manual of mount, we descript remount as below: > > "mount -o remount,rw /dev/foo /dir > After this call all old mount options are replaced and arbitrary stuff from > fstab is ignored, except the loop= option which is internally generated and > maintained by the mount command." > > Previously f2fs do not clear up old mount options when remount_fs, so we have no > chance of disabling previous option (e.g. flush_merge). Fix it. Please don't. "Remount" should just change what you specified and keep others unchanged. The problem here is that we need to provide mount opts for disable/enable some features, but we missed it. So the right way is adding these opts if we really need them. Thanks, Gu > > Signed-off-by: Chao Yu > --- > fs/f2fs/super.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 54444bb..90fcbe0 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -616,6 +616,9 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) > org_mount_opt = sbi->mount_opt; > active_logs = sbi->active_logs; > > + sbi->mount_opt.opt = 0; > + sbi->active_logs = NR_CURSEG_TYPE; > + > /* parse mount options */ > err = parse_options(sb, data); > if (err)