Re: [PATCH v4 0/2] nfacct: add filter in to the list operation

[Alexey Perevalov <a.perevalov@samsung.com>]

On 09/15/2014 08:45 PM, Pablo Neira Ayuso wrote:
> On Fri, Sep 12, 2014 at 02:56:56PM +0400, Alexey Perevalov wrote:
>> Hello Pablo,
>>
>> It's fourth version of patch for filtering, but also with fix for argument
>> singleness.
> Applied, thanks Alexey.
>
> I have made also some mostly comestic changes on it:
>
> - Avoid line break at 80 chars in strncmp(). We can replace strncmp by
>    a new function that takes only two parameters, then avoid the line
>    break.
>
> - Removed NFACCT_F_QUOTAS, it's only used once. We can introduce this
>    later if we have more spots where we can use it.
>
> - Rename quota-bytes to bytes-quota and quota-packets to pkts-quota.
>    The reason for this is that nfacct allows shortened syntax, eg.
>
>    nfacct l r
>
> which is actually 'list reset'. By swapping the words, we can now use:
>
>    nfacct l r p
>
> which only resets packet-based quotas.
Thank you for collaboration,
btw, I know about command line shortened syntax, but it also allows 
following:
nfacct li res
instead of nfacct list reset,
and I was wonder bug it or not )

>


-- 
Best regards,
Alexey Perevalov