From: Paul Sherwood <paul.sherwood@codethink.co.uk>
To: Anand Jain <Anand.Jain@oracle.com>,
Sam Thursfield <sam.thursfield@codethink.co.uk>
Cc: Chris Mason <clm@fb.com>,
linux-btrfs@vger.kernel.org, baserock-dev@baserock.org
Subject: Re: Unable to mount multiple subvolumes of a single disk
Date: Tue, 16 Sep 2014 08:46:10 +0100 [thread overview]
Message-ID: <5417EAC2.80607@codethink.co.uk> (raw)
In-Reply-To: <5417250B.9030105@oracle.com>
Hi Anand
On 15/09/2014 18:42, Anand Jain wrote:
>>> The patch fixes the issue, although it took a little tweaking to get it
>>> to apply cleanly.
I'm working with Sam. This is what I applied, and it works:
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 340a92d..2c87b72 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -533,7 +533,7 @@ static noinline int device_list_add(const char *path,
* the btrfs dev scan cli, after FS has been mounted.
*/
if (fs_devices->opened) {
- return -EBUSY;
+ goto out;
} else {
/*
* That is if the FS is _not_ mounted and if you
@@ -570,6 +570,8 @@ static noinline int device_list_add(const char *path,
fs_devices->latest_devid = devid;
fs_devices->latest_trans = found_transid;
}
+
+out:
*fs_devices_ret = fs_devices;
return ret;
> Sam,
>
> In the above context, Can you pls share the btrfs fi show output ?
btrfs fi show gives:
Label: 'src2' uuid: c2fcd4f8-cc40-4fab-b13b-0d1268afb497
Total devices 1 FS bytes used 77.93GB
devid 1 size 100.00GB used 100.00GB path /dev/sdb
Label: 'baserock' uuid: 129aff8f-65d9-4a19-9e2e-c3826bf5087d
Total devices 1 FS bytes used 3.11GB
devid 1 size 4.00GB used 4.00GB path /dev/sda
Btrfs v0.20-rc1-334-g304f215
br
Paul
next prev parent reply other threads:[~2014-09-16 7:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 15:13 Unable to mount multiple subvolumes of a single disk Sam Thursfield
2014-09-15 15:54 ` Chris Mason
2014-09-15 16:09 ` Anand Jain
2014-09-15 17:13 ` Sam Thursfield
2014-09-15 17:21 ` Anand Jain
2014-09-15 17:42 ` Anand Jain
2014-09-16 7:46 ` Paul Sherwood [this message]
2014-09-16 21:08 ` Stefan G. Weichinger
2014-09-16 21:53 ` Anand Jain
2014-09-17 4:41 ` Anand Jain
2014-09-15 20:38 ` xavier.gnata
2014-09-16 13:23 ` Chris Mason
2014-09-17 9:47 ` Anand Jain
2014-09-17 13:21 ` Chris Mason
2014-09-22 12:04 ` Stefan G. Weichinger
2014-09-15 16:42 ` Anand Jain
2014-09-15 17:15 ` Sam Thursfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5417EAC2.80607@codethink.co.uk \
--to=paul.sherwood@codethink.co.uk \
--cc=Anand.Jain@oracle.com \
--cc=baserock-dev@baserock.org \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sam.thursfield@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.