diff for duplicates of <5417EC7B.4060400@huawei.com> diff --git a/a/1.txt b/N1/1.txt index b6cf5c6..9966ab6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,7 +9,7 @@ On 2014/9/16 15:00, Jiang Liu wrote: >>> - start += scope->length; >>> - } >>> + for (i = 0; i < MAX_HPET_TBS; i++) ->>> + if (ir_hpet[i].iommu = iommu) +>>> + if (ir_hpet[i].iommu == iommu) >>> + ir_hpet[i].iommu = NULL; >> >> Hi Gerry, why not reset whole ir_hpe and ir_ioapic data struct? @@ -33,7 +33,7 @@ static struct intel_iommu *map_hpet_to_ir(u8 hpet_id) int i; for (i = 0; i < MAX_HPET_TBS; i++) - if (ir_hpet[i].id = hpet_id) + if (ir_hpet[i].id == hpet_id) return ir_hpet[i].iommu; return NULL; } @@ -47,7 +47,7 @@ static struct intel_iommu *map_hpet_to_ir(u8 hpet_id) >>> >>> - return 0; >>> + for (i = 0; i < MAX_IO_APICS; i++) ->>> + if (ir_ioapic[i].iommu = iommu) +>>> + if (ir_ioapic[i].iommu == iommu) >>> + ir_ioapic[i].iommu = NULL; >>> } >>> diff --git a/a/content_digest b/N1/content_digest index b683c17..84e634c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\05417E00D.5000108@linux.intel.com\0" "From\0Yijing Wang <wangyijing@huawei.com>\0" "Subject\0Re: [Patch Part3 V5 5/8] iommu/vt-d: Enhance intel_irq_remapping driver to support DMAR unit hotplug\0" - "Date\0Tue, 16 Sep 2014 07:53:31 +0000\0" + "Date\0Tue, 16 Sep 2014 15:53:31 +0800\0" "To\0Jiang Liu <jiang.liu@linux.intel.com>" Joerg Roedel <joro@8bytes.org> David Woodhouse <dwmw2@infradead.org> @@ -33,7 +33,7 @@ ">>> -\t\tstart += scope->length;\n" ">>> -\t}\n" ">>> +\tfor (i = 0; i < MAX_HPET_TBS; i++)\n" - ">>> +\t\tif (ir_hpet[i].iommu = iommu)\n" + ">>> +\t\tif (ir_hpet[i].iommu == iommu)\n" ">>> +\t\t\tir_hpet[i].iommu = NULL;\n" ">>\n" ">> Hi Gerry, why not reset whole ir_hpe and ir_ioapic data struct?\n" @@ -57,7 +57,7 @@ "\tint i;\n" "\n" "\tfor (i = 0; i < MAX_HPET_TBS; i++)\n" - "\t\tif (ir_hpet[i].id = hpet_id)\n" + "\t\tif (ir_hpet[i].id == hpet_id)\n" "\t\t\treturn ir_hpet[i].iommu;\n" "\treturn NULL;\n" "}\n" @@ -71,7 +71,7 @@ ">>> \n" ">>> -\treturn 0;\n" ">>> +\tfor (i = 0; i < MAX_IO_APICS; i++)\n" - ">>> +\t\tif (ir_ioapic[i].iommu = iommu)\n" + ">>> +\t\tif (ir_ioapic[i].iommu == iommu)\n" ">>> +\t\t\tir_ioapic[i].iommu = NULL;\n" ">>> }\n" ">>> \n" @@ -91,4 +91,4 @@ "Thanks!\n" Yijing -9a27808d3547cfc6d9900608b5e6838fd4a9d952585322e47186c137b71e9853 +81e6b02dc4c0b7d4887a959bcbd5417ca1bc086dcf2cbd546f9afc2dc284c7c8
diff --git a/a/1.txt b/N2/1.txt index b6cf5c6..9966ab6 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -9,7 +9,7 @@ On 2014/9/16 15:00, Jiang Liu wrote: >>> - start += scope->length; >>> - } >>> + for (i = 0; i < MAX_HPET_TBS; i++) ->>> + if (ir_hpet[i].iommu = iommu) +>>> + if (ir_hpet[i].iommu == iommu) >>> + ir_hpet[i].iommu = NULL; >> >> Hi Gerry, why not reset whole ir_hpe and ir_ioapic data struct? @@ -33,7 +33,7 @@ static struct intel_iommu *map_hpet_to_ir(u8 hpet_id) int i; for (i = 0; i < MAX_HPET_TBS; i++) - if (ir_hpet[i].id = hpet_id) + if (ir_hpet[i].id == hpet_id) return ir_hpet[i].iommu; return NULL; } @@ -47,7 +47,7 @@ static struct intel_iommu *map_hpet_to_ir(u8 hpet_id) >>> >>> - return 0; >>> + for (i = 0; i < MAX_IO_APICS; i++) ->>> + if (ir_ioapic[i].iommu = iommu) +>>> + if (ir_ioapic[i].iommu == iommu) >>> + ir_ioapic[i].iommu = NULL; >>> } >>> diff --git a/a/content_digest b/N2/content_digest index b683c17..3f67b9f 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,7 +4,7 @@ "ref\05417E00D.5000108@linux.intel.com\0" "From\0Yijing Wang <wangyijing@huawei.com>\0" "Subject\0Re: [Patch Part3 V5 5/8] iommu/vt-d: Enhance intel_irq_remapping driver to support DMAR unit hotplug\0" - "Date\0Tue, 16 Sep 2014 07:53:31 +0000\0" + "Date\0Tue, 16 Sep 2014 15:53:31 +0800\0" "To\0Jiang Liu <jiang.liu@linux.intel.com>" Joerg Roedel <joro@8bytes.org> David Woodhouse <dwmw2@infradead.org> @@ -15,11 +15,11 @@ " Rafael J . Wysocki <rafael.j.wysocki@intel.com>\0" "Cc\0Ashok Raj <ashok.raj@intel.com>" Tony Luck <tony.luck@intel.com> - iommu@lists.linux-foundation.org - linux-pci@vger.kernel.org - linux-hotplug@vger.kernel.org - linux-kernel@vger.kernel.org - " dmaengine@vger.kernel.org\0" + <iommu@lists.linux-foundation.org> + <linux-pci@vger.kernel.org> + <linux-hotplug@vger.kernel.org> + <linux-kernel@vger.kernel.org> + " <dmaengine@vger.kernel.org>\0" "\00:1\0" "b\0" "On 2014/9/16 15:00, Jiang Liu wrote:\n" @@ -33,7 +33,7 @@ ">>> -\t\tstart += scope->length;\n" ">>> -\t}\n" ">>> +\tfor (i = 0; i < MAX_HPET_TBS; i++)\n" - ">>> +\t\tif (ir_hpet[i].iommu = iommu)\n" + ">>> +\t\tif (ir_hpet[i].iommu == iommu)\n" ">>> +\t\t\tir_hpet[i].iommu = NULL;\n" ">>\n" ">> Hi Gerry, why not reset whole ir_hpe and ir_ioapic data struct?\n" @@ -57,7 +57,7 @@ "\tint i;\n" "\n" "\tfor (i = 0; i < MAX_HPET_TBS; i++)\n" - "\t\tif (ir_hpet[i].id = hpet_id)\n" + "\t\tif (ir_hpet[i].id == hpet_id)\n" "\t\t\treturn ir_hpet[i].iommu;\n" "\treturn NULL;\n" "}\n" @@ -71,7 +71,7 @@ ">>> \n" ">>> -\treturn 0;\n" ">>> +\tfor (i = 0; i < MAX_IO_APICS; i++)\n" - ">>> +\t\tif (ir_ioapic[i].iommu = iommu)\n" + ">>> +\t\tif (ir_ioapic[i].iommu == iommu)\n" ">>> +\t\t\tir_ioapic[i].iommu = NULL;\n" ">>> }\n" ">>> \n" @@ -91,4 +91,4 @@ "Thanks!\n" Yijing -9a27808d3547cfc6d9900608b5e6838fd4a9d952585322e47186c137b71e9853 +d59aa356c05abbf8c9957817233c7d22edacd3d54964ce47ae2b1b3d94ad5fd9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.