From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <rth@twiddle.net>,
Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>,
qemu-devel@nongnu.org
Cc: zealot351@gmail.com, maria.klimushenkova@ispras.ru, batuzovk@ispras.ru
Subject: Re: [Qemu-devel] [PATCH] target-i386: update fp status fix
Date: Tue, 16 Sep 2014 10:14:14 +0200 [thread overview]
Message-ID: <5417F156.3020408@redhat.com> (raw)
In-Reply-To: <5417458D.5090508@twiddle.net>
Il 15/09/2014 22:01, Richard Henderson ha scritto:
>> > @@ -1006,6 +1006,7 @@ void helper_fstenv(CPUX86State *env, target_ulong ptr, int data32)
>> > cpu_stw_data(env, ptr + 10, 0);
>> > cpu_stw_data(env, ptr + 12, 0);
>> > }
>> > + update_fp_status(env);
>> > }
> Why does this need to update status?
Ah, this is fstenv (I learnt about it today and misread it as
frstenv...). The update_fd_status is needed in fldenv, and is missing
from this patch.
TeLeMan's suggestion is also good.
Paolo
next prev parent reply other threads:[~2014-09-16 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 11:17 [Qemu-devel] [PATCH] target-i386: update fp status fix Pavel Dovgalyuk
2014-09-15 15:06 ` Paolo Bonzini
2014-09-15 20:01 ` Richard Henderson
2014-09-16 8:14 ` Paolo Bonzini [this message]
2014-09-16 5:42 ` TeLeMan
2014-09-16 5:51 ` TeLeMan
2014-09-16 5:54 ` TeLeMan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5417F156.3020408@redhat.com \
--to=pbonzini@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=batuzovk@ispras.ru \
--cc=maria.klimushenkova@ispras.ru \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=zealot351@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.