All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Brian Norris <computersforpeace@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3 2/3] nand: omap2: Remove horrible ifdefs to fix module probe
Date: Tue, 16 Sep 2014 11:43:59 +0300	[thread overview]
Message-ID: <5417F84F.1010602@ti.com> (raw)
In-Reply-To: <1410447730-16087-3-git-send-email-ezequiel@vanguardiasur.com.ar>

On 09/11/2014 06:02 PM, Ezequiel Garcia wrote:
> The current code abuses ifdefs to determine if the selected ECC scheme
> is supported by the running kernel. As a result the code is hard to read,
> and it also fails to load as a module.
> 
> This commit removes all the ifdefs and instead introduces a function
> omap2_nand_ecc_check() to check if the ECC is supported by using
> IS_ENABLED(CONFIG_xxx).
> 
> Since IS_ENABLED() is true when a config is =y or =m, this change fixes the
> module so it can be loaded with no issues.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger

  reply	other threads:[~2014-09-16  8:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11 15:02 [PATCH v3 0/3] nand: omap2: Two and a half improvements Ezequiel Garcia
2014-09-11 15:02 ` [PATCH v3 1/3] nand: omap2: Add support for flash-based bad block table Ezequiel Garcia
2014-09-16  8:43   ` Roger Quadros
2014-09-18  5:59   ` Brian Norris
2014-09-18  5:59     ` Brian Norris
2014-09-18  7:46     ` Ezequiel Garcia
2014-09-18  7:46       ` Ezequiel Garcia
2014-09-18  8:26       ` Roger Quadros
2014-09-18  8:26         ` Roger Quadros
2014-09-11 15:02 ` [PATCH v3 2/3] nand: omap2: Remove horrible ifdefs to fix module probe Ezequiel Garcia
2014-09-16  8:43   ` Roger Quadros [this message]
2014-09-18  6:03   ` Brian Norris
2014-09-18  6:03     ` Brian Norris
2014-09-18  7:48     ` Ezequiel Garcia
2014-09-18  7:48       ` Ezequiel Garcia
2014-09-11 15:02 ` [PATCH v3 3/3] nand: omap2: Replace pr_err with dev_err Ezequiel Garcia
2014-09-16  8:48   ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5417F84F.1010602@ti.com \
    --to=rogerq@ti.com \
    --cc=computersforpeace@gmail.com \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.