From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx6: fix pl301_mx6qper1_bch clock gating setup
Date: Tue, 16 Sep 2014 11:55:04 +0300 [thread overview]
Message-ID: <5417FAE8.6000103@compulab.co.il> (raw)
In-Reply-To: <1410804262-28853-1-git-send-email-agust@denx.de>
Hi Anatolij,
Please take a look at this patch:
https://www.mail-archive.com/u-boot at lists.denx.de/msg145208.html
function setup_gpmi_io_clk().
It's not in mainline yet, but Stefano already applied it to his tree,
and using it will both fix the problem, and get rid of all this code
duplication.
On 15/09/14 21:04, Anatolij Gustschin wrote:
> Current code sets reserved CG1 bits instead of CG6 bits
> for pl301_mx6qper1_bch clock. Fix it.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Tim Harvey <tharvey@gateworks.com>
> ---
> board/aristainetos/aristainetos.c | 2 +-
> board/barco/titanium/titanium.c | 2 +-
> board/gateworks/gw_ventana/gw_ventana.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/board/aristainetos/aristainetos.c b/board/aristainetos/aristainetos.c
> index 3bfcf5b..bb946b5 100644
> --- a/board/aristainetos/aristainetos.c
> +++ b/board/aristainetos/aristainetos.c
> @@ -433,7 +433,7 @@ static void setup_gpmi_nand(void)
> MXC_CCM_CCGR4_RAWNAND_U_GPMI_BCH_INPUT_BCH_MASK |
> MXC_CCM_CCGR4_RAWNAND_U_GPMI_BCH_INPUT_GPMI_IO_MASK |
> MXC_CCM_CCGR4_RAWNAND_U_GPMI_INPUT_APB_MASK |
> - MXC_CCM_CCGR4_PL301_MX6QPER1_BCH_OFFSET);
> + MXC_CCM_CCGR4_PL301_MX6QPER1_BCH_MASK);
>
> /* enable apbh clock gating */
> setbits_le32(&mxc_ccm->CCGR0, MXC_CCM_CCGR0_APBHDMA_MASK);
> diff --git a/board/barco/titanium/titanium.c b/board/barco/titanium/titanium.c
> index 84a7b84..bcf45a2 100644
> --- a/board/barco/titanium/titanium.c
> +++ b/board/barco/titanium/titanium.c
> @@ -177,7 +177,7 @@ static void setup_gpmi_nand(void)
> MXC_CCM_CCGR4_RAWNAND_U_GPMI_BCH_INPUT_BCH_MASK |
> MXC_CCM_CCGR4_RAWNAND_U_GPMI_BCH_INPUT_GPMI_IO_MASK |
> MXC_CCM_CCGR4_RAWNAND_U_GPMI_INPUT_APB_MASK |
> - MXC_CCM_CCGR4_PL301_MX6QPER1_BCH_OFFSET);
> + MXC_CCM_CCGR4_PL301_MX6QPER1_BCH_MASK);
>
> /* enable apbh clock gating */
> setbits_le32(&mxc_ccm->CCGR0, MXC_CCM_CCGR0_APBHDMA_MASK);
> diff --git a/board/gateworks/gw_ventana/gw_ventana.c b/board/gateworks/gw_ventana/gw_ventana.c
> index a222921..b51c104 100644
> --- a/board/gateworks/gw_ventana/gw_ventana.c
> +++ b/board/gateworks/gw_ventana/gw_ventana.c
> @@ -259,7 +259,7 @@ static void setup_gpmi_nand(void)
> MXC_CCM_CCGR4_RAWNAND_U_GPMI_BCH_INPUT_BCH_MASK |
> MXC_CCM_CCGR4_RAWNAND_U_GPMI_BCH_INPUT_GPMI_IO_MASK |
> MXC_CCM_CCGR4_RAWNAND_U_GPMI_INPUT_APB_MASK |
> - MXC_CCM_CCGR4_PL301_MX6QPER1_BCH_OFFSET);
> + MXC_CCM_CCGR4_PL301_MX6QPER1_BCH_MASK);
>
> /* enable apbh clock gating */
> setbits_le32(&mxc_ccm->CCGR0, MXC_CCM_CCGR0_APBHDMA_MASK);
>
--
Regards,
Nikita Kiryanov
next prev parent reply other threads:[~2014-09-16 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 18:04 [U-Boot] [PATCH] imx6: fix pl301_mx6qper1_bch clock gating setup Anatolij Gustschin
2014-09-16 8:55 ` Nikita Kiryanov [this message]
2014-09-16 18:32 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5417FAE8.6000103@compulab.co.il \
--to=nikita@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.