From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 16 Sep 2014 12:56:13 +0200 Subject: [U-Boot] [PATCH 3/3] arm: mx35: use common timer functions In-Reply-To: <1407853561-23688-4-git-send-email-andrew.ruder@elecsyscorp.com> References: <1407853561-23688-1-git-send-email-andrew.ruder@elecsyscorp.com> <1407853561-23688-4-git-send-email-andrew.ruder@elecsyscorp.com> Message-ID: <5418174D.8010501@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andrew, On 12/08/2014 16:26, andrew.ruder at elecsyscorp.com wrote: > From: Andrew Ruder > > This patch moves mx35 to the common timer functions added in commit > > 8dfafdd - Introduce common timer functions > > The (removed) mx35 timer code (specifically __udelay()) could deadlock at > the 32-bit boundary of get_ticks(). get_ticks() returned a 32-bit value > cast up to a 64-bit value. If get_ticks() + tmo in __udelay() crossed > the 32-bit boundary, the while condition became unconditionally true and > locks the processor. Rather than patch the specific mx35 issues, simply > move everything over to the common code. > > Signed-off-by: Andrew Ruder > Cc: Marek Vasut > Cc: Stefano Babic > --- > > This patch has been COMPILE tested only. The situation isn't quite as > bad on mx35 as 32-bit rollover occurs in about a day and a half. > I have applied both patches for MX31 and MX35, even if I had no time to make myself a test. I hope in this way there is more testers before release. Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================