From: Martin Kelly <martin@martingkelly.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: x86@kernel.org, vishwesh.m.rudramuni@intel.com, joe@perches.com,
hpa@linux.intel.com, aubrey.li@linux.intel.com,
linux-kernel@vger.kernel.org, Martin Kelly <martkell@amazon.com>
Subject: Re: [PATCH] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n
Date: Tue, 16 Sep 2014 07:56:08 -0700 [thread overview]
Message-ID: <54184F88.60001@martingkelly.com> (raw)
In-Reply-To: <20140916063850.GB14807@gmail.com>
On 09/15/2014 11:38 PM, Ingo Molnar wrote:
>
> This uglifies the code which is bad. A nicer fix would be to
> improve the code: for example define pmc_dbgfs_register() in the
> !DEBUG_FS case as well, with a return 0 or so.
>
> Thanks,
>
> Ingo
>
I like your suggestion and will issue a revision.
prev parent reply other threads:[~2014-09-16 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 4:24 [PATCH] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n Martin Kelly
2014-09-16 6:38 ` Ingo Molnar
2014-09-16 14:56 ` Martin Kelly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54184F88.60001@martingkelly.com \
--to=martin@martingkelly.com \
--cc=aubrey.li@linux.intel.com \
--cc=hpa@linux.intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martkell@amazon.com \
--cc=mingo@kernel.org \
--cc=vishwesh.m.rudramuni@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.