From: Steffen Maier <maier@linux.vnet.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
James Bottomley <jbottomley@parallels.com>,
David Miller <davem@davemloft.net>
Cc: Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH -net] scsi: fix users of SCSI_FC_ATTRS to depend on NET
Date: Tue, 16 Sep 2014 16:56:55 +0200 [thread overview]
Message-ID: <54184FB7.7020201@linux.vnet.ibm.com> (raw)
In-Reply-To: <5417DA29.4060205@infradead.org>
On 09/16/2014 08:35 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> There are other kconfig symbols which select SCSI_FC_ATTRS,
> so they also need to depend on NET to fix kconfig warnings and
> build errors:
>
> warning: (LIBFC && SCSI_IBMVFC && SCSI_QLA_FC && SCSI_LPFC && ZFCP && SCSI_BFA_FC && SCSI_CHELSIO_FCOE && FUSION_FC) selects SCSI_FC_ATTRS which has unmet direct dependencies (SCSI && NET)
> drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_event':
> drivers/scsi/scsi_transport_fc.c:543:7: error: 'scsi_nl_sock' undeclared (first use in this function)
> drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_vendor_event':
> drivers/scsi/scsi_transport_fc.c:611:7: error: 'scsi_nl_sock' undeclared (first use in this function)
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/message/fusion/Kconfig | 2 +-
> drivers/scsi/Kconfig | 9 +++++----
> drivers/scsi/csiostor/Kconfig | 2 +-
> drivers/scsi/qla2xxx/Kconfig | 2 +-
> 4 files changed, 8 insertions(+), 7 deletions(-)
> --- lnx-317-rc5.orig/drivers/scsi/Kconfig
> +++ lnx-317-rc5/drivers/scsi/Kconfig
> @@ -1675,7 +1676,7 @@ config SCSI_SUNESP
>
> config ZFCP
> tristate "FCP host bus adapter driver for IBM eServer zSeries"
> - depends on S390 && QDIO && SCSI
> + depends on S390 && QDIO && SCSI && NET
> select SCSI_FC_ATTRS
> help
> If you want to access SCSI devices attached to your IBM eServer
I think zfcp does not have any (direct) dependency on NET.
It looks like SCSI_FC_ATTRS selects SCSI_NETLINK (declaring
scsi_nl_sock) and only depends on SCSI but not on NET.
SCSI_NETLINK itself only selects NET but does not model its direct
depencency on NET?
Do I understand correctly, that the only solution is to make all
INdirect (transitive) dependencies explicit with the LLDDs instead of
making the direct exploiter SCSI_NETLINK(?) depend on NET?
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on System z Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2014-09-16 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 6:35 [PATCH -net] scsi: fix users of SCSI_FC_ATTRS to depend on NET Randy Dunlap
2014-09-16 14:56 ` Steffen Maier [this message]
2014-09-16 16:41 ` David Miller
2014-09-16 20:15 ` David Miller
2014-09-16 20:24 ` Randy Dunlap
2014-09-16 20:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54184FB7.7020201@linux.vnet.ibm.com \
--to=maier@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.