All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: dedekind1@gmail.com
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: xfstests on UBIFS - first findings
Date: Tue, 16 Sep 2014 17:50:55 +0200	[thread overview]
Message-ID: <54185C5F.1050609@nod.at> (raw)
In-Reply-To: <1410882292.28850.60.camel@sauron.fi.intel.com>

Am 16.09.2014 17:44, schrieb Artem Bityutskiy:
> On Mon, 2014-09-15 at 11:13 +0200, Richard Weinberger wrote:
>> One can simple trigger it by doing:
>> # mknod foo c 0 0
>> # setfattr -h -n trusted.name foo
>>
>> dir_ui->data_len is 4 instead of 0.
> 
> I think the assertion is bogus. It was correct before the xattr support
> was added.
> 
> The assertion basically is: if the inode is a directory inode, it should
> not have data in it.
> 
> In that function, dir_ui (directory UBIFS inode) may be also be the
> "host" inode for the xattr entry, so it is not necessarily a directory
> inode at all.
> 
> So the variable should be re-named to "host_ui" instead of "dir_ui".

Thanks for the explanation.
I'll prepare a patch for that and give more testing tomorrow!

Thanks,
//richard

      reply	other threads:[~2014-09-16 15:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15  9:13 xfstests on UBIFS - first findings Richard Weinberger
2014-09-16 15:44 ` Artem Bityutskiy
2014-09-16 15:50   ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54185C5F.1050609@nod.at \
    --to=richard@nod.at \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.