From: Vlad Yasevich <vyasevich@gmail.com>
To: Michael Chan <mchan@broadcom.com>
Cc: Prashant Sreedharan <prashant@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: tg3 issue with tcp checksums and vlan packets
Date: Tue, 16 Sep 2014 14:45:57 -0400 [thread overview]
Message-ID: <54188565.7040600@gmail.com> (raw)
In-Reply-To: <1410886475.7520.73.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
On 09/16/2014 12:54 PM, Michael Chan wrote:
> On Tue, 2014-09-16 at 12:43 -0400, Vlad Yasevich wrote:
>> Prashant and Michael
>>
>> I am seeing a strange issue with tg3 driver when I try to pass to it tcp packets
>> that have partial checksums and inline (non-accelerated) vlan header.
>>
>
> Are you disabling NETIF_F_HW_VLAN_CTAG_TX? I believe TX checksum and
> TSO won't work. We need to add some code to disable both when VLAN
> acceleration is disabled.
>
>
No, in this case, I am simply creating an 802.1ad vlan on top. Since
tg3 doesn't provide ETIF_F_HW_VLAN_STAG_TX, we follow the non-accelerated
path.
Currently the driver doesn't appear to be offer ability to disable vlan acceleration.
However, if any software devices on top of the card do not support it for some reason,
then the issue would be seen as well.
-vlad
prev parent reply other threads:[~2014-09-16 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 16:43 tg3 issue with tcp checksums and vlan packets Vlad Yasevich
2014-09-16 16:54 ` Michael Chan
2014-09-16 18:45 ` Vlad Yasevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54188565.7040600@gmail.com \
--to=vyasevich@gmail.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.