From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Roy Franz <roy.franz@linaro.org>,
stefano.stabellini@eu.citrix.com, tim@xen.org,
Fu Wei <fu.wei@linaro.org>,
xen-devel@lists.xen.org
Subject: Re: [PATCH for-4.5 v2 2/2] xen: arm: Enable physical address space compression (PDX) on arm32
Date: Tue, 16 Sep 2014 13:49:47 -0700 [thread overview]
Message-ID: <5418A26B.4080604@linaro.org> (raw)
In-Reply-To: <1410896030.23505.34.camel@citrix.com>
Hi Ian,
On 16/09/14 12:33, Ian Campbell wrote:
> On Fri, 2014-09-12 at 16:00 -0700, Julien Grall wrote:
>>> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
>>> index 1c3abcf..59b2887 100644
>>> --- a/xen/include/asm-arm/config.h
>>> +++ b/xen/include/asm-arm/config.h
>>> @@ -126,7 +126,12 @@
>>> #define CONFIG_SEPARATE_XENHEAP 1
>>>
>>> #define FRAMETABLE_VIRT_START _AT(vaddr_t,0x02000000)
>>> -#define VMAP_VIRT_START _AT(vaddr_t,0x10000000)
>>> +#define FRAMETABLE_SIZE MB(128-32)
>>
>> I would add a comment about why the frametable size is "MB(128-32)".
>
> There is a big comment just above here which gives an overview of the
> virtual address space layout. I don't think it needs repeating here.
Hmm right. I haven't look at include/asm-arm/config.h, sorry.
Regards,
--
Julien Grall
prev parent reply other threads:[~2014-09-16 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 15:14 [PATCH for-4.5 v2 0/2] Support for sparse physical address space on ARM Ian Campbell
2014-09-12 15:15 ` [PATCH for-4.5 v2 1/2] xen: refactor physical address space compression support into common code Ian Campbell
2014-09-12 15:32 ` Jan Beulich
2014-09-12 15:35 ` Ian Campbell
2014-09-12 15:15 ` [PATCH for-4.5 v2 2/2] xen: arm: Enable physical address space compression (PDX) on arm32 Ian Campbell
2014-09-12 23:00 ` Julien Grall
2014-09-16 19:33 ` Ian Campbell
2014-09-16 20:49 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5418A26B.4080604@linaro.org \
--to=julien.grall@linaro.org \
--cc=fu.wei@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.