All of lore.kernel.org
 help / color / mirror / Atom feed
From: xerofoify@gmail.com (nick)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] staging wlan-ng: Add missing a blank line after declarations
Date: Tue, 16 Sep 2014 17:23:05 -0400	[thread overview]
Message-ID: <5418AA39.7000207@gmail.com> (raw)
In-Reply-To: <1410902457-11392-1-git-send-email-xerofoify@gmail.com>



On 14-09-16 05:20 PM, Nicholas Krause wrote:
> Fixing trivial checkpatch warnings about missing line after declarations
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 1f2c78c..20d146b 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
>  static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>  {
>  	int result = 0;
> +
>  	result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
>  	if (result == 0)
>  		*((u16 *) val) = le16_to_cpu(*((u16 *) val));
> @@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>  static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
>  {
>  	u16 value = cpu_to_le16(val);
> +
>  	return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
>  }
>  
> @@ -1402,6 +1404,7 @@ static inline int
>  hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
>  {
>  	u16 value = cpu_to_le16(val);
> +
>  	return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
>  					    NULL, NULL);
>  }
> 
I checked this patch and there seems to be issues that any of you have stated before after not applying or grammar e.t.c. If there are any other errors I am missing please let me known.
Nick 

  reply	other threads:[~2014-09-16 21:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16 21:20 [PATCH] staging wlan-ng: Add missing a blank line after declarations Nicholas Krause
2014-09-16 21:23 ` nick [this message]
2014-09-16 21:40   ` Valdis.Kletnieks at vt.edu
2014-09-16 21:24 ` Robert P. J. Day
2014-09-16 21:39 ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5418AA39.7000207@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.