From: Randy Dunlap <rdunlap@infradead.org>
To: myungjoo.ham@samsung.com, "Jean Delvare" <jdelvare@suse.de>,
최찬우 <cw00.choi@samsung.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: sm5502: Depend on I2C
Date: Tue, 16 Sep 2014 16:41:53 -0700 [thread overview]
Message-ID: <5418CAC1.7080407@infradead.org> (raw)
In-Reply-To: <6256746.443221410910747510.JavaMail.weblogic@epml01>
On 09/16/14 16:39, MyungJoo Ham wrote:
>> The SM5502 chip is an I2C device so its drivers must depend on I2C.
>> Failing to do so results in build failures on kernels where I2C is
>> not enabled.
>>
>> Signed-off-by: Jean Delvare <jdelvare@suse.de>
>> Cc: Chanwoo Choi <cw00.choi@samsung.com>
>
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Geert sent this same patch. I sent this same patch.
What happened to those patches?
>
>> ---
>> drivers/extcon/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- a/drivers/extcon/Kconfig
>> +++ b/drivers/extcon/Kconfig
>> @@ -72,6 +72,7 @@ config EXTCON_PALMAS
>>
>> config EXTCON_SM5502
>> tristate "SM5502 EXTCON support"
>> + depends on I2C
>> select IRQ_DOMAIN
>> select REGMAP_I2C
>> select REGMAP_IRQ
>>
>> --
>> Jean Delvare
>> SUSE L3 Support
--
~Randy
next prev parent reply other threads:[~2014-09-16 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 23:39 [PATCH] extcon: sm5502: Depend on I2C MyungJoo Ham
2014-09-16 23:41 ` Randy Dunlap [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-16 16:51 Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5418CAC1.7080407@infradead.org \
--to=rdunlap@infradead.org \
--cc=cw00.choi@samsung.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.