From: "Janusz Użycki" <j.uzycki@elproma.com.pl>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] serial: mxs-auart: use mctrl_gpio helpers for handling modem signals (v2.2)
Date: Wed, 17 Sep 2014 11:50:29 +0200 [thread overview]
Message-ID: <54195965.10007@elproma.com.pl> (raw)
In-Reply-To: <1410945333-26250-1-git-send-email-j.uzycki@elproma.com.pl>
W dniu 2014-09-17 11:15, Janusz Uzycki pisze:
> static struct platform_device_id mxs_auart_devtype[] = {
> @@ -417,6 +431,34 @@ static void mxs_auart_set_mctrl(struct uart_port *u, unsigned mctrl)
>
> s->ctrl = mctrl;
> writel(ctrl, u->membase + AUART_CTRL2);
> +
> + mctrl_gpio_set(s->gpios, mctrl);
> +}
@@ -429,7 +429,12 @@ static void mxs_auart_set_mctrl(struct uart_port
*u, unsigned mctrl)
ctrl |= AUART_CTRL2_RTS;
}
+#if 0
s->ctrl = mctrl;
+#else
+ s->ctrl &= ~(TIOCM_RTS | TIOCM_DTR);
+ s->ctrl |= mctrl & (TIOCM_RTS | TIOCM_DTR);
+#endif
writel(ctrl, u->membase + AUART_CTRL2);
mctrl_gpio_set(s->gpios, mctrl);
Does tty layer modify mctrl for input lines and code above is required?
best regards
Janusz
prev parent reply other threads:[~2014-09-17 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 9:15 [PATCH 1/4] serial: mxs-auart: use mctrl_gpio helpers for handling modem signals (v2.2) Janusz Uzycki
2014-09-17 9:15 ` [PATCH 2/4] serial: mxs-auart: add interrupts for modem control lines Janusz Uzycki
2014-09-17 9:15 ` [PATCH 3/4] serial: mxs-auart: enable PPS support Janusz Uzycki
2014-09-17 9:15 ` [PATCH 4/4] serial: mxs-auart: add sysrq support Janusz Uzycki
2014-09-17 9:50 ` Janusz Użycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54195965.10007@elproma.com.pl \
--to=j.uzycki@elproma.com.pl \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.