From: Tang Chen <tangchen@cn.fujitsu.com>
To: Hu Tao <hutao@cn.fujitsu.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: Andrey Korolyov <andrey@xdel.ru>,
mst@redhat.com, luonengjun@huawei.com, qemu-devel@nongnu.org,
peter.huangpeng@huawei.com, imammedo@redhat.com,
pbonzini@redhat.com, tangchen@cn.fujitsu.com,
gaowanlong@cn.fujitsu.com
Subject: Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature
Date: Wed, 17 Sep 2014 18:00:59 +0800 [thread overview]
Message-ID: <54195BDB.9060604@cn.fujitsu.com> (raw)
In-Reply-To: <20140917083220.GA17032@G08FNSTD100614.fnst.cn.fujitsu.com>
Add Andrey Korolyov <andrey@xdel.ru>
On 09/17/2014 04:32 PM, Hu Tao wrote:
> On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote:
>> If we do not configure numa option, memory hotplug should work as well.
>> It should not depend on numa option.
>>
>> Steps to reproduce:
>> (1) Start VM: qemu-kvm -m 1024,slots=4,maxmem=8G
>> (2) Hotplug memory
>> It will fail and reports:
>> "'DIMM property node has value 0' which exceeds the number of numa nodes: 0"
>>
> I rememberd Tang Chen had a patch for this bug, this is what Andrey suggested:
>
> I thnk that there should be no
> cases when dimm is plugged (and check from patch is fired up) without
> actually populated NUMA, because not every OS will workaround this by
> faking the node.
According to Andrey Korolyov <andrey@xdel.ru>, memory hotplug should not
work without SRAT. So maybe forcing to create a NUMA node and SRAT will be
better idea.
I'm have been working on it.
Thanks.
>
> https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg04587.html
>
> Have you tested this patch with Windows guest?
>
> Regards,
> Hu
>
>
next prev parent reply other threads:[~2014-09-17 9:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 10:39 [Qemu-devel] [PATCH 0/2] fix two bugs about numa _and_ hotplug memory feature zhanghailiang
2014-09-16 10:39 ` [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break " zhanghailiang
2014-09-17 8:32 ` Hu Tao
2014-09-17 9:25 ` zhanghailiang
2014-09-17 10:00 ` Tang Chen [this message]
2014-09-17 10:19 ` Andrey Korolyov
2014-09-18 0:58 ` Hu Tao
2014-09-19 12:26 ` Igor Mammedov
2014-09-22 9:03 ` Tang Chen
2014-09-22 9:46 ` zhanghailiang
2014-09-23 8:40 ` Igor Mammedov
2014-09-23 8:58 ` Tang Chen
2014-09-23 10:11 ` zhanghailiang
2014-09-23 10:32 ` Tang Chen
2014-09-23 11:12 ` Igor Mammedov
2014-09-23 12:38 ` zhanghailiang
2014-09-19 12:37 ` Igor Mammedov
2014-09-22 11:17 ` Michael S. Tsirkin
2014-09-23 9:01 ` Igor Mammedov
2014-09-23 10:07 ` zhanghailiang
2014-09-23 11:13 ` Igor Mammedov
2014-09-16 10:39 ` [Qemu-devel] [PATCH 2/2] numa/pc-dimm: Fix stat of memory size in node when hotplug memory zhanghailiang
2014-09-16 11:20 ` Igor Mammedov
2014-09-17 8:22 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54195BDB.9060604@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=andrey@xdel.ru \
--cc=gaowanlong@cn.fujitsu.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=luonengjun@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.