From mboxrd@z Thu Jan 1 00:00:00 1970 From: xerofoify@gmail.com (nick) Date: Wed, 17 Sep 2014 07:55:50 -0400 Subject: A quick guide to why stand-alone checkpatch patches suck... In-Reply-To: References: <140649.1410913551@turing-police.cc.vt.edu> <153669.1410925338@turing-police.cc.vt.edu> <20140917045628.GB19159@kroah.com> <541972B5.3060403@gmail.com> Message-ID: <541976C6.40508@gmail.com> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On 14-09-17 07:53 AM, Robert P. J. Day wrote: > > what did i say? what did i just say? i wrote: > > On Wed, 17 Sep 2014, nick wrote: >> On 14-09-17 07:20 AM, Robert P. J. Day wrote: >>> >>> and, as we've all seen, nick's other flaw is that, quite simply, >>> he's selfish and greedy. his entire obsession is with the output >>> of checkpatch, which means he wants to grab all the trivial >>> cleanup (the low-hanging fruit, as it were) for himself, and not >>> leave any for others. rather than take the time to understand the > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>> code, nick wants checkpatch to do all the work for him. in the >>> end, nick doesn't want to do any work or understand how the kernel >>> actually works -- he just wants patches, and he wants them as >>> quickly and cheaply as possible. > > to which nick responds (unbelievably, and confirming what i had > just written): > >> That's not what I wanted I was trying to improve my rep after >> getting banned from vger.org and now it seems I can't even get a >> patch right. In addition I was trying to do check patch because it >> was easier for me due to not understanding some parts of the code. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > i rarely have my speculation confirmed so rapidly and completely. > > rday > Rday, I meant I didn't understand the code not the effect to write good solid patches and learn it. Please read my messages more carefully. Nick