From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUEsE-00036N-Do for qemu-devel@nongnu.org; Wed, 17 Sep 2014 09:02:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUEs9-0008Nh-Ge for qemu-devel@nongnu.org; Wed, 17 Sep 2014 09:02:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUEs9-0008NP-87 for qemu-devel@nongnu.org; Wed, 17 Sep 2014 09:02:13 -0400 Message-ID: <54198640.4050209@redhat.com> Date: Wed, 17 Sep 2014 07:01:52 -0600 From: Eric Blake MIME-Version: 1.0 References: <1410890642-6704-1-git-send-email-cnanakos@grnet.gr> <1410890642-6704-2-git-send-email-cnanakos@grnet.gr> <54189228.6090907@redhat.com> <54195155.2010001@grnet.gr> In-Reply-To: <54195155.2010001@grnet.gr> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5cHtGM2wWB5ot8COgCSxxFFPgf2FqreqT" Subject: Re: [Qemu-devel] [PATCH v3] async: aio_context_new(): Handle event_notifier_init failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chrysostomos Nanakos , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pingfank@linux.vnet.ibm.com, famz@redhat.com, benoit@irqsave.net, jan.kiszka@siemens.com, stefanha@redhat.com, mjt@tls.msk.ru, kroosec@gmail.com, sw@weilnetz.de, pbonzini@redhat.com, afaerber@suse.de, aliguori@amazon.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5cHtGM2wWB5ot8COgCSxxFFPgf2FqreqT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/17/2014 03:16 AM, Chrysostomos Nanakos wrote: > On 09/16/2014 10:40 PM, Eric Blake wrote: >> On 09/16/2014 12:04 PM, Chrysostomos Nanakos wrote: >>> If event_notifier_init fails QEMU exits without printing >>> any error information to the user. This commit adds an error >>> message on failure: >>> >>> # qemu [...] >> Showing the actual command line you used would be helpful. >=20 > The problem raised after having a system with a low limit of open files= > and QEMU with 8 iothread objects. Do you believe that we should add suc= h > a command line in the commit description? The problem can be easily > reproduced with any combination of low limit of open files and iothread= > objects or even a low limit of open files without the creation of > iothreads. It is ALWAYS valuable to make your commit message give a good recipe for how to reproduce the problem your commit is fixing. It's not a prerequisite (a patch can be accepted on inspection alone), but giving full details of how to reproduce it makes life easier when revisiting the patch a year from now or when writing a test case to ensure no regressions. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5cHtGM2wWB5ot8COgCSxxFFPgf2FqreqT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUGYZAAAoJEKeha0olJ0Nqmr4H/2QxFhqxcaizBW/3w1acMN/5 Z+0YLyZfOBMuUSA9dsNHIBkHUSCGgOMWzqWmaOeO5LdDYtY0jeG+D9woT++1Gek6 ftdZCN0bjOLlRQ3Bb5vNaGoIQg8leCxmAf4Rf+fFse9MiIYLPz7YZetlsmZoeA7Y gzaryeFbdm8Hgu8l2BfHJwtoDztU+C6zIjenotY2c5kVax/8FgBmOu7Jlfd3YrbN ZbzxHSThcC5qqZ1HiZBuhRVAob7GPKpQjfsGYbTKFFJvJhkXoY9OkNSpDZPn054s Fw+TXasxJEMkshCGg1UJ0hEJITHGSCYdI4WK6UFU+QhsQe+3d04+Ki7ihr9jFSI= =vvb7 -----END PGP SIGNATURE----- --5cHtGM2wWB5ot8COgCSxxFFPgf2FqreqT--