From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUF8E-0008LJ-MC for qemu-devel@nongnu.org; Wed, 17 Sep 2014 09:18:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUF87-0004R5-6T for qemu-devel@nongnu.org; Wed, 17 Sep 2014 09:18:50 -0400 Received: from averel.grnet-hq.admin.grnet.gr ([195.251.29.3]:57237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUF86-0004QE-Vj for qemu-devel@nongnu.org; Wed, 17 Sep 2014 09:18:43 -0400 Message-ID: <54198A2A.9090907@grnet.gr> Date: Wed, 17 Sep 2014 16:18:34 +0300 From: Chrysostomos Nanakos MIME-Version: 1.0 References: <1410890642-6704-1-git-send-email-cnanakos@grnet.gr> <1410890642-6704-2-git-send-email-cnanakos@grnet.gr> <54189228.6090907@redhat.com> <54195155.2010001@grnet.gr> <54198640.4050209@redhat.com> In-Reply-To: <54198640.4050209@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] async: aio_context_new(): Handle event_notifier_init failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pingfank@linux.vnet.ibm.com, famz@redhat.com, benoit@irqsave.net, jan.kiszka@siemens.com, stefanha@redhat.com, mjt@tls.msk.ru, kroosec@gmail.com, sw@weilnetz.de, pbonzini@redhat.com, afaerber@suse.de, aliguori@amazon.com On 09/17/2014 04:01 PM, Eric Blake wrote: > On 09/17/2014 03:16 AM, Chrysostomos Nanakos wrote: >> On 09/16/2014 10:40 PM, Eric Blake wrote: >>> On 09/16/2014 12:04 PM, Chrysostomos Nanakos wrote: >>>> If event_notifier_init fails QEMU exits without printing >>>> any error information to the user. This commit adds an error >>>> message on failure: >>>> >>>> # qemu [...] >>> Showing the actual command line you used would be helpful. >> The problem raised after having a system with a low limit of open files >> and QEMU with 8 iothread objects. Do you believe that we should add such >> a command line in the commit description? The problem can be easily >> reproduced with any combination of low limit of open files and iothread >> objects or even a low limit of open files without the creation of >> iothreads. > It is ALWAYS valuable to make your commit message give a good recipe for > how to reproduce the problem your commit is fixing. It's not a > prerequisite (a patch can be accepted on inspection alone), but giving > full details of how to reproduce it makes life easier when revisiting > the patch a year from now or when writing a test case to ensure no > regressions. > No problem Eric, thanks for the advice. I will make the appropriates changes to the commit log and resend the patch. Regards, Chrysostomos.