From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS Date: Wed, 17 Sep 2014 09:49:20 -0400 Message-ID: <54199160.7090401@fb.com> References: <1410766234-1634-1-git-send-email-behanw@converseincode.com> <1410766234-1634-3-git-send-email-behanw@converseincode.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1410766234-1634-3-git-send-email-behanw@converseincode.com> Sender: linux-security-module-owner@vger.kernel.org To: behanw@converseincode.com, agk@redhat.com, davem@davemloft.net, dm-devel@redhat.com, fabf@skynet.be, herbert@gondor.apana.org.au, jbacik@fb.com, snitzer@redhat.com, tadeusz.struk@intel.com Cc: akpm@linux-foundation.org, bruce.w.allan@intel.com, d.kasatkin@samsung.com, james.l.morris@oracle.com, john.griffin@intel.com, linux-btrfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linux-ima-user@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-security-module@vger.kernel.org, neilb@suse.de, qat-linux@intel.com, serge@hallyn.com, thomas.lendacky@amd.com, zohar@linux.vnet.ibm.com, torvalds@linux-foundation.org, =?UTF-8?B?Vmluw61jaXVzIFRpbnRp?= List-Id: dm-devel.ids On 09/15/2014 03:30 AM, behanw@converseincode.com wrote: > From: Vin=C3=ADcius Tinti >=20 > Replaced the use of a Variable Length Array In Struct (VLAIS) with a = C99 > compliant equivalent. This is the original VLAIS struct. >=20 > struct { > struct shash_desc shash; > char ctx[crypto_shash_descsize(tfm)]; > } desc; >=20 > This patch instead allocates the appropriate amount of memory using a > char array using the SHASH_DESC_ON_STACK macro. >=20 > The new code can be compiled with both gcc and clang. >=20 > Signed-off-by: Vin=C3=ADcius Tinti > Reviewed-by: Jan-Simon M=C3=B6ller > Reviewed-by: Mark Charlebois > Signed-off-by: Behan Webster > Cc: "David S. Miller" > Cc: Herbert Xu Acked-by: Chris Mason On the btrfs bits. Thanks for the v3. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-securit= y-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:61935 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755346AbaIQNuM (ORCPT ); Wed, 17 Sep 2014 09:50:12 -0400 Message-ID: <54199160.7090401@fb.com> Date: Wed, 17 Sep 2014 09:49:20 -0400 From: Chris Mason MIME-Version: 1.0 To: , , , , , , , , CC: , , , , , , , , , , , , , , , , , , =?UTF-8?B?Vmluw61jaXVzIFRpbnRp?= Subject: Re: [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS References: <1410766234-1634-1-git-send-email-behanw@converseincode.com> <1410766234-1634-3-git-send-email-behanw@converseincode.com> In-Reply-To: <1410766234-1634-3-git-send-email-behanw@converseincode.com> Content-Type: text/plain; charset="UTF-8" Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 09/15/2014 03:30 AM, behanw@converseincode.com wrote: > From: Vinícius Tinti > > Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99 > compliant equivalent. This is the original VLAIS struct. > > struct { > struct shash_desc shash; > char ctx[crypto_shash_descsize(tfm)]; > } desc; > > This patch instead allocates the appropriate amount of memory using a > char array using the SHASH_DESC_ON_STACK macro. > > The new code can be compiled with both gcc and clang. > > Signed-off-by: Vinícius Tinti > Reviewed-by: Jan-Simon Möller > Reviewed-by: Mark Charlebois > Signed-off-by: Behan Webster > Cc: "David S. Miller" > Cc: Herbert Xu Acked-by: Chris Mason On the btrfs bits. Thanks for the v3. -chris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS Date: Wed, 17 Sep 2014 09:49:20 -0400 Message-ID: <54199160.7090401@fb.com> References: <1410766234-1634-1-git-send-email-behanw@converseincode.com> <1410766234-1634-3-git-send-email-behanw@converseincode.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: , , , , , , , , , , , , , , , , , , =?UTF-8?B?Vmluw61jaXVzIFRpbnRp?= To: , , , , , , , , Return-path: In-Reply-To: <1410766234-1634-3-git-send-email-behanw@converseincode.com> Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On 09/15/2014 03:30 AM, behanw@converseincode.com wrote: > From: Vin=C3=ADcius Tinti >=20 > Replaced the use of a Variable Length Array In Struct (VLAIS) with a = C99 > compliant equivalent. This is the original VLAIS struct. >=20 > struct { > struct shash_desc shash; > char ctx[crypto_shash_descsize(tfm)]; > } desc; >=20 > This patch instead allocates the appropriate amount of memory using a > char array using the SHASH_DESC_ON_STACK macro. >=20 > The new code can be compiled with both gcc and clang. >=20 > Signed-off-by: Vin=C3=ADcius Tinti > Reviewed-by: Jan-Simon M=C3=B6ller > Reviewed-by: Mark Charlebois > Signed-off-by: Behan Webster > Cc: "David S. Miller" > Cc: Herbert Xu Acked-by: Chris Mason On the btrfs bits. Thanks for the v3. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-securit= y-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html