From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [net-next PATCH v2] net: sched: cls_u32: rcu can not be last node Date: Wed, 17 Sep 2014 11:03:42 -0700 Message-ID: <5419CCFE.8030906@gmail.com> References: <20140917173108.3864.57490.stgit@nitbit.x32> <1410976082.7106.239.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: xiyou.wangcong@gmail.com, davem@davemloft.net, netdev@vger.kernel.org, jhs@mojatatu.com To: Eric Dumazet Return-path: Received: from mail-oa0-f50.google.com ([209.85.219.50]:40082 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756084AbaIQSDy (ORCPT ); Wed, 17 Sep 2014 14:03:54 -0400 Received: by mail-oa0-f50.google.com with SMTP id jd19so1589523oac.9 for ; Wed, 17 Sep 2014 11:03:53 -0700 (PDT) In-Reply-To: <1410976082.7106.239.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: On 09/17/2014 10:48 AM, Eric Dumazet wrote: > On Wed, 2014-09-17 at 10:31 -0700, John Fastabend wrote: >> tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the >> structure and pads the structure with tc_u32_key fields for each key. >> >> kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL) >> >> CC: Eric Dumazet >> Signed-off-by: John Fastabend >> --- >> net/sched/cls_u32.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c >> index eceeb04..8462132 100644 >> --- a/net/sched/cls_u32.c >> +++ b/net/sched/cls_u32.c >> @@ -64,8 +64,9 @@ struct tc_u_knode { >> u32 __percpu *pcpu_success; >> #endif >> struct tcf_proto *tp; >> - struct tc_u32_sel sel; >> struct rcu_head rcu; >> + struct tc_u32_sel sel; >> + /* tc_u32_keys allocated at end of structure */ >> }; >> >> struct tc_u_hnode { > > Sorry to be picky, but comment should be before 'sel' or at same line. no problem lets get it right, I'll post a v3 now and write a better comment. > > It should mention that 'sel' MUST be last field. > > Thanks ! > -- John Fastabend Intel Corporation