From: Chris Zhong <zyw@rock-chips.com>
To: Doug Anderson <dianders@chromium.org>, Mark Brown <broonie@kernel.org>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Tao Huang" <huangtao@rock-chips.com>,
"Eddie Cai" <cf@rock-chips.com>,
zhangqing <zhangqing@rock-chips.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] regulator: st-pwm: get voltage and duty table from dts
Date: Thu, 18 Sep 2014 09:37:41 +0800 [thread overview]
Message-ID: <541A3765.50606@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=UYdBDf+dvUp8U6qbW3CgrMP3vtF_yDamBYwSjZVJ42Qw@mail.gmail.com>
On 09/18/2014 12:54 AM, Doug Anderson wrote:
> Hi,
>
> On Wed, Sep 17, 2014 at 9:51 AM, Mark Brown <broonie@kernel.org> wrote:
>> On Wed, Sep 17, 2014 at 09:07:59PM +0800, Chris Zhong wrote:
>>> Get voltage & duty table from device tree might be better, other platforms can also use this
>>> driver without any modify.
>>>
>>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>>> ---
>>>
>>> drivers/regulator/Kconfig | 1 -
>>> drivers/regulator/st-pwm.c | 80 +++++++++++++++++++++++---------------------
>> You need to update the binding document if you're updating the DT
>> bindings.
> Mark: See part 2 <https://patchwork.kernel.org/patch/4924381/>.
> Unfortunately you weren't CCed on that. It also should have been
> patch #1, not patch #2.
>
> Chris: please change the order and make sure Mark is CCed on the
> bindings. Probably anyone CCed on the code change should be on the
> bindings change (and probably vice versa, but maybe not as critical).
>
> -Doug
>
>
Thanks.
I should not only use patman's script to created cc list.
next prev parent reply other threads:[~2014-09-18 1:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 13:07 [PATCH 0/2] regulator: get voltage & duty table from dts for st-pwm Chris Zhong
2014-09-17 13:07 ` Chris Zhong
2014-09-17 13:07 ` [PATCH 1/2] regulator: st-pwm: get voltage and duty table from dts Chris Zhong
2014-09-17 15:15 ` Heiko Stübner
2014-09-17 16:51 ` Mark Brown
2014-09-17 16:54 ` Doug Anderson
2014-09-18 1:37 ` Chris Zhong [this message]
2014-09-18 3:36 ` Doug Anderson
2014-09-17 18:28 ` Doug Anderson
2014-09-17 21:26 ` Lee Jones
2014-09-17 13:08 ` [PATCH 2/2] dt-bindings: add devicetree bindings for st-pwm regulator Chris Zhong
[not found] ` <1410959280-29662-3-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-09-17 18:16 ` Doug Anderson
2014-09-17 18:16 ` Doug Anderson
[not found] ` <CAD=FV=WCQ4oU1O9JcZ9SuwWJ7g+GLsUiE=wmQQoWvL41o24eWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-17 18:35 ` Mark Brown
2014-09-17 18:35 ` Mark Brown
2014-09-17 19:46 ` Mark Rutland
2014-09-17 19:46 ` Mark Rutland
2014-09-17 21:22 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541A3765.50606@rock-chips.com \
--to=zyw@rock-chips.com \
--cc=broonie@kernel.org \
--cc=cf@rock-chips.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.