From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v5 2/4] dt-bindings: document Rockchip thermal Date: Thu, 18 Sep 2014 10:33:05 +0800 Message-ID: <541A4461.4080101@rock-chips.com> References: <1410926353-15674-1-git-send-email-caesar.wang@rock-chips.com> <1410926353-15674-3-git-send-email-caesar.wang@rock-chips.com> <20140917201347.GD25297@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from regular1.263xmail.com ([211.150.99.131]:50465 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757377AbaIRCdO (ORCPT ); Wed, 17 Sep 2014 22:33:14 -0400 In-Reply-To: <20140917201347.GD25297@core.coreip.homeip.net> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Dmitry Torokhov , Doug Anderson Cc: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , Zhang Rui , edubezval@gmail.com, Arnd Bergmann , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , Tao Huang , Eddie Cai , Dmitry Torokhov , Addy Ke , zyf , =?UTF-8?B?6ZmI5riQ6aOe?= =E5=9C=A8 2014=E5=B9=B409=E6=9C=8818=E6=97=A5 04:13, Dmitry Torokhov =E5= =86=99=E9=81=93: > On Wed, Sep 17, 2014 at 12:48:16PM -0700, Doug Anderson wrote: >> Caesar, >> >> On Tue, Sep 16, 2014 at 8:59 PM, Caesar Wang wrote: >>> This add the necessary binding documentation for the thermal >>> found on Rockchip SoCs >>> >>> Signed-off-by: zhaoyifeng >>> Signed-off-by: Caesar Wang >>> --- >>> .../bindings/thermal/rockchip-thermal.txt | 41 +++++++++= +++++++++++++ >>> 1 file changed, 41 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/thermal/rock= chip-thermal.txt >>> >>> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-the= rmal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.t= xt >>> new file mode 100644 >>> index 0000000..6fc8bc3 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.tx= t >>> @@ -0,0 +1,41 @@ >>> +* Temperature Sensor ADC (TSADC) on rockchip SoCs >>> + >>> +Required properties: >>> +- compatible: "rockchip,rk3288-tsadc" >>> +- reg: physical base address of the controller and length of memor= y mapped >>> + region. >>> +- interrupts: The interrupt number to the cpu. The interrupt speci= fier format >>> + depends on the interrupt controller. >>> +- clocks: Must contain an entry for each entry in clock-names. >>> +- clock-names: Shall be "tsadc" for the converter-clock, and "apb_= pclk" for >>> + the peripheral clock. >>> +- num-trips: number of total trip points, this is required, set i= t 0 if none, >>> + if greater than 0, the following properties must be d= efined; >> nit: there is whitespace damage (space before tab) on the line befor= e >> this one. It's more obvious in the patch you uploaded to gerrit whi= ch >> highlights this in red: >> >> https://chromium-review.googlesource.com/#/c/213967/5/Documentation/= devicetree/bindings/thermal/rockchip-thermal.txt >> >> Did you run your patches through checkpatch before submitting? > FWIW vim users like me can put the following in their .vimrc file to > have whitespace damage visible right away: > > :highlight RedundantSpaces ctermbg=3Dred guibg=3Dred > :match RedundantSpaces /\s\+$\| \+\ze\t/ > > Thanks. It's a very useful, Thank you for sharing. --=20 Best regards, Caesar From mboxrd@z Thu Jan 1 00:00:00 1970 From: caesar.wang@rock-chips.com (Caesar Wang) Date: Thu, 18 Sep 2014 10:33:05 +0800 Subject: [PATCH v5 2/4] dt-bindings: document Rockchip thermal In-Reply-To: <20140917201347.GD25297@core.coreip.homeip.net> References: <1410926353-15674-1-git-send-email-caesar.wang@rock-chips.com> <1410926353-15674-3-git-send-email-caesar.wang@rock-chips.com> <20140917201347.GD25297@core.coreip.homeip.net> Message-ID: <541A4461.4080101@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2014?09?18? 04:13, Dmitry Torokhov ??: > On Wed, Sep 17, 2014 at 12:48:16PM -0700, Doug Anderson wrote: >> Caesar, >> >> On Tue, Sep 16, 2014 at 8:59 PM, Caesar Wang wrote: >>> This add the necessary binding documentation for the thermal >>> found on Rockchip SoCs >>> >>> Signed-off-by: zhaoyifeng >>> Signed-off-by: Caesar Wang >>> --- >>> .../bindings/thermal/rockchip-thermal.txt | 41 ++++++++++++++++++++++ >>> 1 file changed, 41 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >>> >>> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >>> new file mode 100644 >>> index 0000000..6fc8bc3 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >>> @@ -0,0 +1,41 @@ >>> +* Temperature Sensor ADC (TSADC) on rockchip SoCs >>> + >>> +Required properties: >>> +- compatible: "rockchip,rk3288-tsadc" >>> +- reg: physical base address of the controller and length of memory mapped >>> + region. >>> +- interrupts: The interrupt number to the cpu. The interrupt specifier format >>> + depends on the interrupt controller. >>> +- clocks: Must contain an entry for each entry in clock-names. >>> +- clock-names: Shall be "tsadc" for the converter-clock, and "apb_pclk" for >>> + the peripheral clock. >>> +- num-trips: number of total trip points, this is required, set it 0 if none, >>> + if greater than 0, the following properties must be defined; >> nit: there is whitespace damage (space before tab) on the line before >> this one. It's more obvious in the patch you uploaded to gerrit which >> highlights this in red: >> >> https://chromium-review.googlesource.com/#/c/213967/5/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> >> Did you run your patches through checkpatch before submitting? > FWIW vim users like me can put the following in their .vimrc file to > have whitespace damage visible right away: > > :highlight RedundantSpaces ctermbg=red guibg=red > :match RedundantSpaces /\s\+$\| \+\ze\t/ > > Thanks. It's a very useful, Thank you for sharing. -- Best regards, Caesar