From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Michel_D=E4nzer?= Subject: Re: [PATCH 6/8] drm/radeon: cope with foreign fences inside the reservation object Date: Thu, 18 Sep 2014 12:26:12 +0900 Message-ID: <541A50D4.4000403@daenzer.net> References: <1410957305-10190-1-git-send-email-maarten.lankhorst@canonical.com> <1410957305-10190-7-git-send-email-maarten.lankhorst@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 14C166E4B9 for ; Wed, 17 Sep 2014 20:26:17 -0700 (PDT) In-Reply-To: <1410957305-10190-7-git-send-email-maarten.lankhorst@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 17.09.2014 21:35, Maarten Lankhorst wrote: > diff --git a/drivers/gpu/drm/radeon/radeon_semaphore.c b/drivers/gpu/drm/= radeon/radeon_semaphore.c > index 4d4b0773638a..68311da39c09 100644 > --- a/drivers/gpu/drm/radeon/radeon_semaphore.c > +++ b/drivers/gpu/drm/radeon/radeon_semaphore.c > @@ -124,27 +124,39 @@ void radeon_semaphore_sync_fence(struct radeon_sema= phore *semaphore, > * > * Sync to the fence using this semaphore object > */ > -void radeon_semaphore_sync_resv(struct radeon_semaphore *sema, > - struct reservation_object *resv, > - bool shared) > +int radeon_semaphore_sync_resv(struct radeon_device *rdev, > + struct radeon_semaphore *sema, > + struct reservation_object *resv, > + bool shared, bool intr) The callers of this function would be more readable if it took flags = instead of the shared and intr bools. -- = Earthling Michel D=E4nzer | http://www.amd.com Libre software enthusiast | Mesa and X developer