From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Liang Chen <liangchen.linux@gmail.com>, pbonzini@redhat.com
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com
Subject: Re: [PATCH v2] KVM: x86: count actual tlb flushes
Date: Thu, 18 Sep 2014 13:05:31 +0800 [thread overview]
Message-ID: <541A681B.1020503@linux.vnet.ibm.com> (raw)
In-Reply-To: <1410978955-19003-1-git-send-email-liangchen.linux@gmail.com>
On 09/18/2014 02:35 AM, Liang Chen wrote:
> - we count KVM_REQ_TLB_FLUSH requests, not actual flushes
> (KVM can have multiple requests for one flush)
> - flushes from kvm_flush_remote_tlbs aren't counted
> - it's easy to make a direct request by mistake
>
> Solve these by postponing the counting to kvm_check_request(),
It's good.
> and refactor the code to use kvm_make_request again.
Why this refactor is needed? It's really a bad idea using
raw-bit-set instead of meaningful name.
[ Btw, maybe kvm_mmu_flush_local_tlb is a better name than
kvm_mmu_flush_tlb() in the current code. ]
next prev parent reply other threads:[~2014-09-18 5:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 18:35 [PATCH v2] KVM: x86: count actual tlb flushes Liang Chen
2014-09-18 5:05 ` Xiao Guangrong [this message]
2014-09-18 12:47 ` Paolo Bonzini
2014-09-18 13:49 ` Liang Chen
2014-09-18 14:08 ` Radim Krčmář
2014-09-18 14:00 ` Radim Krčmář
2014-09-18 14:47 ` Liang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541A681B.1020503@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=liangchen.linux@gmail.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.