From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: [PATCH 1/5] btrfs: nodatasum drop compress
Date: Thu, 18 Sep 2014 17:25:59 +0900 [thread overview]
Message-ID: <541A9717.5000003@jp.fujitsu.com> (raw)
From: Naohiro Aota <naota@elisp.net>
We can enable both compress option and nodatasum option at the same time
with the following command.
===
$ sudo mount -o remount,compress,nodatasum /
$ mount | grep btrfs
/dev/vda2 on / type btrfs (rw,relatime,seclabel,nodatasum,compress=zlib,space_cache)
===
This behavior collides with Documentation/filesystems/btrfs.txt:
===
...
If compression is enabled, nodatacow and nodatasum are disabled.
...
===
This patch drops the compress flags upon nodatasum flag.
Signed-off-by: Naohiro Aota <naota@elisp.net>
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
---
fs/btrfs/super.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index c4124de..d1c5b6d 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -440,8 +440,15 @@ int btrfs_parse_options(struct btrfs_root *root, char *options)
*/
break;
case Opt_nodatasum:
- btrfs_set_and_info(root, NODATASUM,
- "setting nodatasum");
+ if (!btrfs_test_opt(root, NODATASUM)) {
+ if (btrfs_test_opt(root, COMPRESS))
+ btrfs_info(root->fs_info, "setting nodatasum, compression disabled");
+ else
+ btrfs_info(root->fs_info, "setting nodatasum");
+ }
+ btrfs_clear_opt(info->mount_opt, COMPRESS);
+ btrfs_clear_opt(info->mount_opt, FORCE_COMPRESS);
+ btrfs_set_opt(info->mount_opt, NODATASUM);
break;
case Opt_datasum:
if (btrfs_test_opt(root, NODATASUM)) {
-- 1.8.3.1
next reply other threads:[~2014-09-18 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 8:25 Satoru Takeuchi [this message]
2014-09-18 8:28 ` [PATCH 2/5] btrfs: correct a message on setting nodatacow Satoru Takeuchi
2014-09-19 2:03 ` Qu Wenruo
2014-09-19 6:45 ` Satoru Takeuchi
2014-09-19 7:01 ` Qu Wenruo
2014-09-18 8:30 ` [PATCH 3/5] btrfs: notice nodatasum is also enabled with nodatacow Satoru Takeuchi
2014-09-18 8:32 ` [PATCH 4/5] btrfs: suppress a verbose message about enabling space cache on remounting Satoru Takeuchi
2014-09-18 8:43 ` [PATCH 5/5] btrfs: rework compression related options processing Satoru Takeuchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541A9717.5000003@jp.fujitsu.com \
--to=takeuchi_satoru@jp.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.