Re: [Qemu-devel] [PATCH V3 0/7] cpu/acpi: convert cpu hot plug to hotplug_handler API

[Gu Zheng <guz.fnst@cn.fujitsu.com>]

Hi Igor,
The issues you mentioned in previous comments are fixed in this version.
Could please help to review it?

Thanks,
Gu

On 09/17/2014 09:23 AM, Gu Zheng wrote:

> Previously we use cpu_added_notifiers to register cpu hotplug notifier callback
> which is not able to pass/handle errors, so we switch it to unified hotplug
> handler API which allows to pass errors and would allow to cancel device_add
> in case of error.
> Thanks very much for Igor's review and suggestion.
> 
> v3:
>  -deal with start-up cpus in pc_cpu_plug as Igor suggested.
> 
> v2:
>  -Add 3 new patches(5/7,6/7,7/7), delete original patch 5/5.
>   1/5-->1/7
>   2/5-->2/7
>   3/5-->3/7
>   4/5-->4/7
>  Patch 1/7:
>  -add errp argument to catch error.
>  -return error instead of aborting if cpu id is invalid.
>  -make acpi_cpu_plug_cb as a wrapper around AcpiCpuHotplug_add.
>  Patch 3/7:
>  -remove unused AcpiCpuHotplug_add directly.
>  Patch 5/7:
>  -switch the last user of cpu hotplug notifier to hotplug handler API, and
>   remove the unused cpu hotplug notify.
>  Patch 6/7:
>  -split the function rename (just cleanup) into single patch.
>  Patch 7/7:
>  -introduce help function acpi_set_local_sts to keep the bit setting in
>   one place.
> 
> Gu Zheng (7):
>   acpi/cpu: add cpu hotplug callback function to match hotplug_handler
>     API
>   acpi:ich9: convert cpu hotplug handle to hotplug_handler API
>   acpi:piix4: convert cpu hotplug handle to hotplug_handler API
>   pc: add cpu hotplug handler to PC_MACHINE
>   pc: Update rtc_cmos in pc_cpu_plug
>   cpu-hotplug: rename function for better readability
>   acpi/cpu-hotplug: introduce help function to keep bit setting in one
>     place
> 
>  hw/acpi/cpu_hotplug.c         |   35 ++++++++++++++++++++--------
>  hw/acpi/ich9.c                |   18 ++++----------
>  hw/acpi/piix4.c               |   18 +++-----------
>  hw/i386/pc.c                  |   51 +++++++++++++++++++++++++----------------
>  include/hw/acpi/cpu_hotplug.h |    7 +++--
>  include/hw/acpi/ich9.h        |    1 -
>  include/sysemu/sysemu.h       |    3 --
>  qom/cpu.c                     |   10 --------
>  8 files changed, 69 insertions(+), 74 deletions(-)
>