Re: [Qemu-devel] [PATCH 19/19] usb-bus: remove "init" from USBDeviceClass struct

[Paolo Bonzini <pbonzini@redhat.com>]

Il 18/09/2014 11:33, arei.gonglei@huawei.com ha scritto:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> All usb-bus devices are realized by realize(),
> remove init callback function from USBDeviceClass struct.
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  hw/usb/bus.c     | 2 --
>  include/hw/usb.h | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/hw/usb/bus.c b/hw/usb/bus.c
> index 12881cb..b375293 100644
> --- a/hw/usb/bus.c
> +++ b/hw/usb/bus.c
> @@ -113,8 +113,6 @@ static void usb_device_realize(USBDevice *dev, Error **errp)
>  
>      if (klass->realize) {
>          klass->realize(dev, errp);
> -    } else if (klass->init) {
> -        klass->init(dev);
>      }
>  }
>  
> diff --git a/include/hw/usb.h b/include/hw/usb.h
> index 612f09f..8ffbba2 100644
> --- a/include/hw/usb.h
> +++ b/include/hw/usb.h
> @@ -273,8 +273,6 @@ typedef void (*USBDeviceUnrealize)(USBDevice *dev, Error **errp);
>  typedef struct USBDeviceClass {
>      DeviceClass parent_class;
>  
> -    int (*init)(USBDevice *dev);
> -
>      USBDeviceRealize realize;
>      USBDeviceUnrealize unrealize;
>  
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>