From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 88F77E00857; Thu, 18 Sep 2014 05:15:29 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] X-Greylist: delayed 557 seconds by postgrey-1.32 at yocto-www; Thu, 18 Sep 2014 05:15:19 PDT Received: from mail.methodpark.de (mail.methodpark.de [212.204.89.242]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 0CEB6E007AA for ; Thu, 18 Sep 2014 05:15:19 -0700 (PDT) Received: from localhost (virusgate [212.204.89.246]) by mail.methodpark.de (Postfix) with ESMTP id A16C033800BF; Thu, 18 Sep 2014 14:04:31 +0200 (CEST) X-Virus-Scanned: by amavisd-new-2.6.6 (20110518) (Debian) at methodpark.de Received: from mail.methodpark.de ([IPv6:::ffff:212.204.89.242]) by localhost (virusgate.methodpark.de [::ffff:212.204.89.246]) (amavisd-new, port 10024) with ESMTP id MlKly62aH-4I; Thu, 18 Sep 2014 14:05:55 +0200 (CEST) Received: from [10.10.101.191] (unknown [10.10.101.191]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.methodpark.de (Postfix) with ESMTPSA id EF61233800B8; Thu, 18 Sep 2014 14:04:26 +0200 (CEST) Message-ID: <541ACAA0.5050000@methodpark.de> Date: Thu, 18 Sep 2014 14:05:52 +0200 From: Simon Kuhnle User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Eric Nelson References: <1406547046-30064-1-git-send-email-simon.kuhnle@methodpark.de> <53F66D5A.5040301@boundarydevices.com> In-Reply-To: <53F66D5A.5040301@boundarydevices.com> X-Mailman-Approved-At: Mon, 22 Sep 2014 07:32:43 -0700 Cc: meta-freescale@yoctoproject.org Subject: Re: [meta-fsl-arm-extra][PATCH] linux-boundary (3.10.17): add CONFIG_USB_G_MULTI X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2014 12:15:29 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Eric, On 08/22/2014 12:06 AM, Eric Nelson wrote: > On 07/28/2014 04:30 AM, Simon Kuhnle wrote: >> >> Signed-off-by: Simon Kuhnle >> --- >> .../nitrogen6x-lite/defconfig | 1 + >> .../linux-boundary-3.10.17/nitrogen6x/defconfig | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig >> index dbe579e..c077a5f 100644 >> --- a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig >> +++ b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig >> @@ -229,6 +229,7 @@ CONFIG_USB_ZERO=m >> CONFIG_USB_ETH=m >> CONFIG_USB_MASS_STORAGE=m >> CONFIG_USB_G_SERIAL=m >> +CONFIG_USB_G_MULTI=m >> CONFIG_MMC=y >> CONFIG_MMC_UNSAFE_RESUME=y >> CONFIG_MMC_SDHCI=y >> diff --git a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig >> index 6bb7159..810d040 100644 >> --- a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig >> +++ b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig >> @@ -242,6 +242,7 @@ CONFIG_USB_ZERO=m >> CONFIG_USB_ETH=m >> CONFIG_USB_MASS_STORAGE=m >> CONFIG_USB_G_SERIAL=m >> +CONFIG_USB_G_MULTI=m >> CONFIG_MMC=y >> CONFIG_MMC_UNSAFE_RESUME=y >> CONFIG_MMC_SDHCI=y >> > > Sorry it took so long to respond. I wanted to test this out for > any regressions. > > I just did, and it looks harmless. I'm still not sure how this > is useful without the inclusion of either or both USB_G_MULTI_CDC or > USB_G_MULTI_RNDIS, but... sorry it took _me_ so long to respond and thank you for applying the patch! If CONFIG_USB_G_MULTI is selected then USB_G_MULTI_RNDIS is selected automatically, at least in the builds I did. According to the help files of both the RNDIS option, as well as the CDC option, choosing RNDIS seems like the best option. Selecting both CDC and RNDIS confuses Windows machines and RNDIS alone should work on Windows out of the box (that I did not test) and it worked on my Ubuntu 14.04. workstation without problems. Maybe I should send in another patch that explicitly enables USB_G_MULTI_RNDIS and unsets USB_G_MULTI_CDC, so it is obvious what happens. Sorry for the confusion. Regards, Simon