From: Eric Blake <eblake@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com,
luonengjun@huawei.com, peter.huangpeng@huawei.com,
qemu-stable@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qga: Fix possible freed memory accessing
Date: Thu, 18 Sep 2014 06:17:57 -0600 [thread overview]
Message-ID: <541ACD75.1040708@redhat.com> (raw)
In-Reply-To: <1411011222-5116-1-git-send-email-zhang.zhanghailiang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On 09/17/2014 09:33 PM, zhanghailiang wrote:
> If readdir_r fails, error_setg_errno will reference the freed
> pointer *dirpath*.
>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> qga/commands-posix.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
> for (;;) {
> if (readdir_r(dir, &entry, &result) != 0) {
Eww. We're using readdir_r? That's an inherently broken interface,
which can risk buffer overflow. readdir should be preferred.
http://austingroupbugs.net/view.php?id=696
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-09-18 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 3:33 [Qemu-devel] [PATCH] qga: Fix possible freed memory accessing zhanghailiang
2014-09-18 7:00 ` Markus Armbruster
2014-09-18 12:17 ` Eric Blake [this message]
2014-09-18 12:42 ` zhanghailiang
2014-09-18 12:53 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541ACD75.1040708@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=luonengjun@huawei.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.