From: Eric Blake <eblake@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: weidong.huang@huawei.com, armbru@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] pci-hotplug-old: avoid lossing error message
Date: Thu, 18 Sep 2014 06:21:53 -0600 [thread overview]
Message-ID: <541ACE61.9020707@redhat.com> (raw)
In-Reply-To: <1411030402-11312-1-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On 09/18/2014 02:53 AM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
s/lossing/losing/ in the subject.
>
> When scsi_bus_legacy_add_drive() produce error,
s/produce error/produces an error/
> we will loss error message. Using error_report
s/loss/lose the/
s/Using error_report/Use error_report to/
> report it.
>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> hw/pci/pci-hotplug-old.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
With the commit message improved,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-09-18 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 8:53 [Qemu-devel] [PATCH] pci-hotplug-old: avoid lossing error message arei.gonglei
2014-09-18 12:21 ` Eric Blake [this message]
2014-09-18 12:32 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541ACE61.9020707@redhat.com \
--to=eblake@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.