All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sasha.levin@oracle.com>
To: Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org
Cc: Ming Lei <ming.lei@canonical.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] firmware_class: make sure fw requests contain a name
Date: Thu, 18 Sep 2014 15:44:28 -0400	[thread overview]
Message-ID: <541B361C.4090302@oracle.com> (raw)
In-Reply-To: <20140918182537.GA10260@www.outflux.net>

On 09/18/2014 02:25 PM, Kees Cook wrote:
> An empty firmware request name will trigger warnings when building
> device names. Make sure this is caught earlier and rejected.
> 
> The warning was visible via the test_firmware.ko module interface:
> 
> echo -ne "\x00" > /sys/devices/virtual/misc/test_firmware/trigger_request
> 
> Reported-by: Sasha Levin <sasha.levin@oracle.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Cc: stable@vger.kernel.org

Works for me!

	Tested-by: Sasha Levin <sasha.levin@oracle.com>


Thanks,
Sasha

      reply	other threads:[~2014-09-18 19:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18 18:25 [PATCH] firmware_class: make sure fw requests contain a name Kees Cook
2014-09-18 19:44 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541B361C.4090302@oracle.com \
    --to=sasha.levin@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.