From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from hauke-m.de ([5.39.93.123]:59639 "EHLO hauke-m.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755864AbaIRUwN (ORCPT ); Thu, 18 Sep 2014 16:52:13 -0400 Message-ID: <541B45FB.3000503@hauke-m.de> (sfid-20140918_225217_531450_A17CF0BA) Date: Thu, 18 Sep 2014 22:52:11 +0200 From: Hauke Mehrtens MIME-Version: 1.0 To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= CC: John Linville , "linux-wireless@vger.kernel.org" , Arend Van Spriel , "linux-arm-kernel@lists.infradead.org" , Arnd Bergmann , devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] bcma: register bcma as device tree driver References: <1410904582-6519-1-git-send-email-hauke@hauke-m.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/18/2014 10:03 PM, Rafał Miłecki wrote: > On 16 September 2014 23:56, Hauke Mehrtens wrote: >> +The cores on the AXI bus are auto detected by bcma. bcma automatically >> +detects the cores > > I'm far from being an English expert, but above is kind of pleonasm to me ;) Yes to me too. ;-) >> and the memory ranges they are using and they get >> +registered afterwards. Automatic detection of the IRQ number is not >> +possible on BCM47xx/BCM53xx ARM and MIPS SoCs. > > Should we replace "not possible" with something like "not reliable"? > After the last info we got from Arend. Yes that sounds good. > > >> +#ifdef CONFIG_BCMA_HOST_SOC >> +/* host_pci.c */ > > s/pci/soc/ > > >> +#ifdef CONFIG_OF >> +extern int __init bcma_host_soc_register_driver(void); >> +extern void __exit bcma_host_soc_unregister_driver(void); >> +#else >> +static inline int __init bcma_host_soc_register_driver(void) >> +{ >> + return 0; >> +} >> +static inline void __exit bcma_host_soc_unregister_driver(void) >> +{ >> +} >> +#endif /* CONFIG_OF */ >> +#endif /* CONFIG_BCMA_HOST_SOC */ > > OK, so you just made bcma_host_soc_(un)register_driver calls safe above. > > >> diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c >> index c421403..e5d578c 100644 >> --- a/drivers/bcma/main.c >> +++ b/drivers/bcma/main.c >> @@ -528,6 +528,13 @@ static int __init bcma_modinit(void) >> if (err) >> return err; >> >> +#ifdef CONFIG_BCMA_HOST_SOC >> + err = bcma_host_soc_register_driver(); >> + if (err) { >> + pr_err("SoC host initialization failed\n"); >> + err = 0; >> + } >> +#endif > > And above you check for CONFIG_ anyway. > Yes that sounds good. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hauke@hauke-m.de (Hauke Mehrtens) Date: Thu, 18 Sep 2014 22:52:11 +0200 Subject: [PATCH v2 1/2] bcma: register bcma as device tree driver In-Reply-To: References: <1410904582-6519-1-git-send-email-hauke@hauke-m.de> Message-ID: <541B45FB.3000503@hauke-m.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/18/2014 10:03 PM, Rafa? Mi?ecki wrote: > On 16 September 2014 23:56, Hauke Mehrtens wrote: >> +The cores on the AXI bus are auto detected by bcma. bcma automatically >> +detects the cores > > I'm far from being an English expert, but above is kind of pleonasm to me ;) Yes to me too. ;-) >> and the memory ranges they are using and they get >> +registered afterwards. Automatic detection of the IRQ number is not >> +possible on BCM47xx/BCM53xx ARM and MIPS SoCs. > > Should we replace "not possible" with something like "not reliable"? > After the last info we got from Arend. Yes that sounds good. > > >> +#ifdef CONFIG_BCMA_HOST_SOC >> +/* host_pci.c */ > > s/pci/soc/ > > >> +#ifdef CONFIG_OF >> +extern int __init bcma_host_soc_register_driver(void); >> +extern void __exit bcma_host_soc_unregister_driver(void); >> +#else >> +static inline int __init bcma_host_soc_register_driver(void) >> +{ >> + return 0; >> +} >> +static inline void __exit bcma_host_soc_unregister_driver(void) >> +{ >> +} >> +#endif /* CONFIG_OF */ >> +#endif /* CONFIG_BCMA_HOST_SOC */ > > OK, so you just made bcma_host_soc_(un)register_driver calls safe above. > > >> diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c >> index c421403..e5d578c 100644 >> --- a/drivers/bcma/main.c >> +++ b/drivers/bcma/main.c >> @@ -528,6 +528,13 @@ static int __init bcma_modinit(void) >> if (err) >> return err; >> >> +#ifdef CONFIG_BCMA_HOST_SOC >> + err = bcma_host_soc_register_driver(); >> + if (err) { >> + pr_err("SoC host initialization failed\n"); >> + err = 0; >> + } >> +#endif > > And above you check for CONFIG_ anyway. > Yes that sounds good. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hauke Mehrtens Subject: Re: [PATCH v2 1/2] bcma: register bcma as device tree driver Date: Thu, 18 Sep 2014 22:52:11 +0200 Message-ID: <541B45FB.3000503@hauke-m.de> References: <1410904582-6519-1-git-send-email-hauke@hauke-m.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: John Linville , "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Arend Van Spriel , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Arnd Bergmann , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 09/18/2014 10:03 PM, Rafa=C5=82 Mi=C5=82ecki wrote: > On 16 September 2014 23:56, Hauke Mehrtens wrote: >> +The cores on the AXI bus are auto detected by bcma. bcma automatica= lly >> +detects the cores >=20 > I'm far from being an English expert, but above is kind of pleonasm t= o me ;) Yes to me too. ;-) >> and the memory ranges they are using and they get >> +registered afterwards. Automatic detection of the IRQ number is not >> +possible on BCM47xx/BCM53xx ARM and MIPS SoCs. >=20 > Should we replace "not possible" with something like "not reliable"? > After the last info we got from Arend. Yes that sounds good. >=20 >=20 >> +#ifdef CONFIG_BCMA_HOST_SOC >> +/* host_pci.c */ >=20 > s/pci/soc/ >=20 >=20 >> +#ifdef CONFIG_OF >> +extern int __init bcma_host_soc_register_driver(void); >> +extern void __exit bcma_host_soc_unregister_driver(void); >> +#else >> +static inline int __init bcma_host_soc_register_driver(void) >> +{ >> + return 0; >> +} >> +static inline void __exit bcma_host_soc_unregister_driver(void) >> +{ >> +} >> +#endif /* CONFIG_OF */ >> +#endif /* CONFIG_BCMA_HOST_SOC */ >=20 > OK, so you just made bcma_host_soc_(un)register_driver calls safe abo= ve. >=20 >=20 >> diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c >> index c421403..e5d578c 100644 >> --- a/drivers/bcma/main.c >> +++ b/drivers/bcma/main.c >> @@ -528,6 +528,13 @@ static int __init bcma_modinit(void) >> if (err) >> return err; >> >> +#ifdef CONFIG_BCMA_HOST_SOC >> + err =3D bcma_host_soc_register_driver(); >> + if (err) { >> + pr_err("SoC host initialization failed\n"); >> + err =3D 0; >> + } >> +#endif >=20 > And above you check for CONFIG_ anyway. >=20 Yes that sounds good. -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html