From: Alan Ott <alan@signal11.us>
To: Varka Bhadram <varkabhadram@gmail.com>,
linux-wpan@vger.kernel.org, linux-bluetooth@vger.kernel.org
Cc: Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH bluetooth-next 2/3] ieee802154: mrf24j40: remove return statement
Date: Thu, 18 Sep 2014 18:55:50 -0400 [thread overview]
Message-ID: <541B62F6.7000506@signal11.us> (raw)
In-Reply-To: <1410842922-10564-3-git-send-email-varkab@cdac.in>
Make the first line of the commit message:
mrf24j40: remove unnecessary return statement
On 09/16/2014 12:48 AM, Varka Bhadram wrote:
> This patch remove the return statement for void function.
> void function return statements are not generally useful.
>
Take out "this patch" and the second line. Make the comment:
Remove the return statement in the void function.
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
> drivers/net/ieee802154/mrf24j40.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index 466da57..2c617e3 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -420,8 +420,6 @@ static void mrf24j40_stop(struct ieee802154_dev *dev)
> return;
> val |= 0x1|0x8; /* Set TXNIE and RXIE. Disable Interrupts */
> write_short_reg(devrec, REG_INTCON, val);
> -
> - return;
> }
>
> static int mrf24j40_set_channel(struct ieee802154_dev *dev,
>
next prev parent reply other threads:[~2014-09-18 22:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 4:48 [PATCH bluetooth-next 0/3] ieee802154: cleanup for mrf24j40 Varka Bhadram
2014-09-16 4:48 ` [PATCH bluetooth-next 1/3] ieee802154: mrf24j40: fix Missing a blank line after declarations Varka Bhadram
2014-09-18 22:54 ` Alan Ott
2014-09-19 3:22 ` Varka Bhadram
2014-09-16 4:48 ` [PATCH bluetooth-next 2/3] ieee802154: mrf24j40: remove return statement Varka Bhadram
2014-09-18 22:55 ` Alan Ott [this message]
2014-09-19 3:21 ` Varka Bhadram
2014-09-16 4:48 ` [PATCH bluetooth-next 3/3] ieee802154: mrf24j40: use pr_* / dev_* Varka Bhadram
2014-09-18 23:01 ` Alan Ott
[not found] ` <541BA2AB.2030503@gmail.com>
2014-09-19 4:25 ` Alan Ott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541B62F6.7000506@signal11.us \
--to=alan@signal11.us \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=varkab@cdac.in \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.