From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 5D580E0085E; Thu, 18 Sep 2014 17:25:44 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.220.53 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 22985E00790 for ; Thu, 18 Sep 2014 17:25:32 -0700 (PDT) Received: by mail-pa0-f53.google.com with SMTP id rd3so2634010pab.40 for ; Thu, 18 Sep 2014 17:25:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=1m/AVRm5JmAxDo+siPlUzf+lJ3CaaVYL78YPBEWv0HY=; b=EZPhs6e3ihXUn3M0OFnoqUvp2HbhSf6cSpmQ93ZkS/hvjQTcLkvsKskCe9m+oqTAQz aZ4WmP5tzOLX7qlr+gw35qHq/PbMLgFL8zGHC4nGbK0hGBRloAhqIEQmZuXb2BFO41xt qamZdb20IldzRgEea+AHI8hUTHsh/2uYqiuJuRDYqFw2EPDb9mHXg1UXnms0Y/OwTnBW TuPT6H6UvBvryy0PyvvtXXFMFxckHPNb6EFpQK1bqopo36rKLGyTM5G8+KnOYO1hZGDe ryMiNxPMtu/cpRllbYrCc64k2PS7UmpgS60j0F6Hs1WZC2qtYpdA1MmGocuMX0nyRCdK DfPQ== X-Gm-Message-State: ALoCoQkx293e+BO/beNynxCfjHvetWHsUC1M1Hovu0hwlyfom6hfBIYXBJrIJiPqhUCOmwZJArGM X-Received: by 10.68.88.33 with SMTP id bd1mr10960686pbb.46.1411086331559; Thu, 18 Sep 2014 17:25:31 -0700 (PDT) Received: from [29.6.1.8] (97-117-169-114.phnx.qwest.net. [97.117.169.114]) by mx.google.com with ESMTPSA id we5sm178246pab.28.2014.09.18.17.25.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Sep 2014 17:25:30 -0700 (PDT) Message-ID: <541B77F7.9040702@boundarydevices.com> Date: Thu, 18 Sep 2014 17:25:27 -0700 From: Eric Nelson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Simon Kuhnle References: <1406547046-30064-1-git-send-email-simon.kuhnle@methodpark.de> <53F66D5A.5040301@boundarydevices.com> <541ACAA0.5050000@methodpark.de> In-Reply-To: <541ACAA0.5050000@methodpark.de> Cc: meta-freescale@yoctoproject.org Subject: Re: [meta-fsl-arm-extra][PATCH] linux-boundary (3.10.17): add CONFIG_USB_G_MULTI X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Sep 2014 00:25:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Simon, On 09/18/2014 05:05 AM, Simon Kuhnle wrote: > Hi Eric, > > On 08/22/2014 12:06 AM, Eric Nelson wrote: >> On 07/28/2014 04:30 AM, Simon Kuhnle wrote: >>> >>> Signed-off-by: Simon Kuhnle >>> --- >>> .../nitrogen6x-lite/defconfig | 1 + >>> .../linux-boundary-3.10.17/nitrogen6x/defconfig | 1 + >>> 2 files changed, 2 insertions(+) >>> >>> diff --git >>> a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig >>> b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig >>> index dbe579e..c077a5f 100644 >>> --- >>> a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig >>> +++ >>> b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x-lite/defconfig >>> @@ -229,6 +229,7 @@ CONFIG_USB_ZERO=m >>> CONFIG_USB_ETH=m >>> CONFIG_USB_MASS_STORAGE=m >>> CONFIG_USB_G_SERIAL=m >>> +CONFIG_USB_G_MULTI=m >>> CONFIG_MMC=y >>> CONFIG_MMC_UNSAFE_RESUME=y >>> CONFIG_MMC_SDHCI=y >>> diff --git >>> a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig >>> b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig >>> index 6bb7159..810d040 100644 >>> --- a/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig >>> +++ b/recipes-kernel/linux/linux-boundary-3.10.17/nitrogen6x/defconfig >>> @@ -242,6 +242,7 @@ CONFIG_USB_ZERO=m >>> CONFIG_USB_ETH=m >>> CONFIG_USB_MASS_STORAGE=m >>> CONFIG_USB_G_SERIAL=m >>> +CONFIG_USB_G_MULTI=m >>> CONFIG_MMC=y >>> CONFIG_MMC_UNSAFE_RESUME=y >>> CONFIG_MMC_SDHCI=y >>> >> >> Sorry it took so long to respond. I wanted to test this out for >> any regressions. >> >> I just did, and it looks harmless. I'm still not sure how this >> is useful without the inclusion of either or both USB_G_MULTI_CDC or >> USB_G_MULTI_RNDIS, but... > > sorry it took _me_ so long to respond and thank you for applying the patch! > No worries. This change was committed to master while you were out! https://github.com/Freescale/meta-fsl-arm-extra/commit/664e70e > If CONFIG_USB_G_MULTI is selected then USB_G_MULTI_RNDIS is selected > automatically, at least in the builds I did. > > According to the help files of both the RNDIS option, as well as the CDC > option, choosing RNDIS seems like the best option. Selecting both CDC > and RNDIS confuses Windows machines and RNDIS alone should work on > Windows out of the box (that I did not test) and it worked on my Ubuntu > 14.04. workstation without problems. > > Maybe I should send in another patch that explicitly enables > USB_G_MULTI_RNDIS and unsets USB_G_MULTI_CDC, so it is obvious what > happens. Sorry for the confusion. > I figured that out, tested, and acked. Thanks for the patch. Eric