From: Timur Tabi <timur@tabi.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: "Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>,
"Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property
Date: Thu, 18 Sep 2014 19:29:32 -0500 [thread overview]
Message-ID: <541B78EC.5050702@tabi.org> (raw)
In-Reply-To: <20140918194342.GA3173@Alpha>
Nicolin Chen wrote:
> Thank you for the comments. Then we may use compatible check for
> P1022 and MPC8610 to limit their DAI formats.
>
> For the property, do you agree to modify it like this:
>
> - fsl,mode: The operating mode for the AC97 interface only.
> "ac97-slave" - AC97 mode, SSI is clock slave
> "ac97-master" - AC97 mode, SSI is clock master
> (There's no need for other DAI format like I2S
> mode to engage this property.)
>
> And how about this patch? I'm personally okay with this change.
> We may also send an extra patch to refine the document after the
> agreement's done.
You can't just redefine a property, because that breaks backwards
compatibility with older device trees or older kernels.
next prev parent reply other threads:[~2014-09-19 0:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1411063877-1552-1-git-send-email-fabio.estevam@freescale.com>
[not found] ` <20140918183251.GE6432@Asurada>
[not found] ` <541B2678.8000401@tabi.org>
2014-09-18 18:46 ` [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property Fabio.Estevam
2014-09-18 19:43 ` Nicolin Chen
2014-09-19 0:29 ` Timur Tabi [this message]
2014-09-19 4:17 ` Nicolin Chen
2014-09-19 12:51 ` Timur Tabi
2014-09-19 17:24 ` Nicolin Chen
2014-09-19 23:49 ` Timur Tabi
2014-09-20 18:07 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541B78EC.5050702@tabi.org \
--to=timur@tabi.org \
--cc=Fabio.Estevam@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.