From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Michel_D=E4nzer?= <michel@daenzer.net>
Subject: Re: [PATCH 6/8] drm/radeon: cope with foreign fences inside the
 reservation object
Date: Fri, 19 Sep 2014 10:19:09 +0900
Message-ID: <541B848D.4090309@daenzer.net>
References: <1410957305-10190-1-git-send-email-maarten.lankhorst@canonical.com>
 <1410957305-10190-7-git-send-email-maarten.lankhorst@canonical.com>
 <541A50D4.4000403@daenzer.net> <541AB273.3090007@canonical.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51])
 by gabe.freedesktop.org (Postfix) with ESMTP id 56D416E02D
 for <dri-devel@lists.freedesktop.org>; Thu, 18 Sep 2014 18:19:15 -0700 (PDT)
In-Reply-To: <541AB273.3090007@canonical.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 18.09.2014 19:22, Maarten Lankhorst wrote:
> Op 18-09-14 om 05:26 schreef Michel D=E4nzer:
>> On 17.09.2014 21:35, Maarten Lankhorst wrote:
>>> diff --git a/drivers/gpu/drm/radeon/radeon_semaphore.c b/drivers/gpu/dr=
m/radeon/radeon_semaphore.c
>>> index 4d4b0773638a..68311da39c09 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_semaphore.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_semaphore.c
>>> @@ -124,27 +124,39 @@ void radeon_semaphore_sync_fence(struct radeon_se=
maphore *semaphore,
>>>     *
>>>     * Sync to the fence using this semaphore object
>>>     */
>>> -void radeon_semaphore_sync_resv(struct radeon_semaphore *sema,
>>> -                struct reservation_object *resv,
>>> -                bool shared)
>>> +int radeon_semaphore_sync_resv(struct radeon_device *rdev,
>>> +                   struct radeon_semaphore *sema,
>>> +                   struct reservation_object *resv,
>>> +                   bool shared, bool intr)
>>
>> The callers of this function would be more readable if it took flags ins=
tead of the shared and intr bools.
> This does not match the rest of the TTM design. Things like
> ttm_bo_reserve take separate bools, not flags.

So? :)


-- =

Earthling Michel D=E4nzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer