From: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
To: Rene Kolarik <rene.kolarik@gmail.com>,
gregkh@linuxfoundation.org, shawn.guo@freescale.com,
kernel@pengutronix.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]imx-drm coding style fixes
Date: Fri, 19 Sep 2014 07:22:13 +0300 [thread overview]
Message-ID: <541BAF75.8050900@gmail.com> (raw)
In-Reply-To: <20140918225736.GA15881@rendy-i5>
On 2014.09.19 01:57, Rene Kolarik wrote:
> Hello,
>
> I've fixed coding style issues in drivers/staging/imx-drm directory. This is a part of Eudyptula Challenge.
Please submit your patches "inline" (look at /Documentation/SubmittingPatches section 7). Also, think about if it's worth seperating this patch into two or more since you are doing more than what you're saying in the description.
Furthermore, your subject line is kind of wrong. Perhaps it should look something like this:
[PATCH] drivers: staging: imx-drm style cleanup (SubmittingPatches section 15)
Finally, you didn't mention what coding style issues you've fixed and these kind of patches are called clean-up patches.
>
> Rene Kolarik
>
>
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
--
thanks,
Giedrius
prev parent reply other threads:[~2014-09-19 4:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 22:57 [PATCH]imx-drm coding style fixes Rene Kolarik
2014-09-19 4:22 ` Giedrius Statkevičius [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541BAF75.8050900@gmail.com \
--to=giedrius.statkevicius@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.kolarik@gmail.com \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.