All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] compulab trimslice build error due to 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus")
Date: Fri, 19 Sep 2014 09:30:51 +0300	[thread overview]
Message-ID: <541BCD9B.8060108@compulab.co.il> (raw)
In-Reply-To: <541B14B7.6090805@wwwdotorg.org>

Hi Stephen,

On 09/18/14 20:21, Stephen Warren wrote:
> After commit 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus"), the trimslice board fails to build with:
> 
> .../board/compulab/common/eeprom.c: In function ?cl_eeprom_read?:
> .../board/compulab/common/eeprom.c:37:24: error: ?CONFIG_SYS_I2C_EEPROM_BUS? undeclared (first use in this function)
> .../board/compulab/common/eeprom.c:37:24: note: each undeclared identifier is reported only once for each function it appears in
> 
> I have no idea if this EEPROM code should even run on TrimSlice or not. Can you take a look at the correct fix?

We have already submitted a temporary fix, see [1].
The intend is to switch to Kconfig for all CompuLab boards
and that will bring the proper fix for the problem.
After this, the temporary fixes can be removed.

[1] https://patchwork.ozlabs.org/patch/390381/

-- 
Regards,
Igor.

      reply	other threads:[~2014-09-19  6:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18 17:21 [U-Boot] compulab trimslice build error due to 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus") Stephen Warren
2014-09-19  6:30 ` Igor Grinberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541BCD9B.8060108@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.