From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: max98090: Fix missing free_irq (part 2)
Date: Fri, 19 Sep 2014 10:51:13 +0300 [thread overview]
Message-ID: <541BE071.1090600@linux.intel.com> (raw)
In-Reply-To: <20140918175434.GA7960@sirena.org.uk>
On 09/18/2014 08:54 PM, Mark Brown wrote:
> On Thu, Sep 18, 2014 at 01:48:44PM +0300, Jarkko Nikula wrote:
>
>> ---
>> for-next, I don't think this is critical enough for stable.
>> ---
>> @@ -2413,6 +2413,7 @@ static int max98090_remove(struct snd_soc_codec *codec)
>> {
>> struct max98090_priv *max98090 = snd_soc_codec_get_drvdata(codec);
>>
>> + devm_free_irq(codec->dev, max98090->irq, codec);
> If this is a fix for -next shouldn't we be doing the proper fix and
> moving the resource acquisition to the bus probe?
Fair enough. I'll cook another version.
--
Jarkko
prev parent reply other threads:[~2014-09-19 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 10:48 [PATCH] ASoC: max98090: Fix missing free_irq (part 2) Jarkko Nikula
2014-09-18 17:54 ` Mark Brown
2014-09-19 7:51 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541BE071.1090600@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.