All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
To: shuang.qiu@oracle.com
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] pan/ltp-pan.c: TCONF testcases should not be written to failcmdfile
Date: Fri, 19 Sep 2014 16:06:48 +0800	[thread overview]
Message-ID: <541BE418.6020501@cn.fujitsu.com> (raw)
In-Reply-To: <1410244166-5559-1-git-send-email-shuang.qiu@oracle.com>

Hi,

    I introduced this patch '6f6878f4e1406d79cae53564777c5e1245d2a124', sorry. I
agree with you, patch looks good to me, thanks! Or we can also create a file to
record test cases that return TCONF.

Regards,
Xiaoguang Wang
 
On 09/09/2014 02:29 PM, shuang.qiu@oracle.com wrote:
> From: Shuang Qiu <shuang.qiu@oracle.com>
> 
> After commit patch 6f6878f4e1406d79cae53564777c5e1245d2a124,the
> testcases which retrun TCONF should not be written to failcmdfile.
> 
> Signed-off-by: Shuang Qiu <shuang.qiu@oracle.com>
> ---
>  pan/ltp-pan.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/pan/ltp-pan.c b/pan/ltp-pan.c
> index 957199a..711c16a 100644
> --- a/pan/ltp-pan.c
> +++ b/pan/ltp-pan.c
> @@ -802,7 +802,7 @@ check_pids(struct tag_pgrp *running, int *num_active, int keep_active,
>  					fflush(logfile);
>  				}
>  
> -				if ((failcmdfile != NULL) && (w != 0)) {
> +				if ((failcmdfile != NULL) && (w != 0) && (w != TCONF)) {
>  					fprintf(failcmdfile, "%s %s\n",
>  						running[i].cmd->name,
>  						running[i].cmd->cmdline);
> 


------------------------------------------------------------------------------
Slashdot TV.  Video for Nerds.  Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2014-09-19  8:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09  6:29 [LTP] [PATCH] pan/ltp-pan.c: TCONF testcases should not be written to failcmdfile shuang.qiu
2014-09-19  8:06 ` Xiaoguang Wang [this message]
2014-09-19 12:35   ` chrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541BE418.6020501@cn.fujitsu.com \
    --to=wangxg.fnst@cn.fujitsu.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=shuang.qiu@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.