From: Paolo Bonzini <pbonzini@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: luonengjun@huawei.com, kraxel@redhat.com,
weidong.huang@huawei.com, peter.huangpeng@huawei.com,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] usb-serial: only check speed once at realize time
Date: Fri, 19 Sep 2014 10:08:02 +0200 [thread overview]
Message-ID: <541BE462.70309@redhat.com> (raw)
In-Reply-To: <1411111521-12540-1-git-send-email-arei.gonglei@huawei.com>
Il 19/09/2014 09:25, arei.gonglei@huawei.com ha scritto:
> From: Gonglei <arei.gonglei@huawei.com>
>
> This patch series based on
> [PATCH v3 00/19] usb: convert device init to realize
>
> As Paolo's comments:
>
> usb port speed check could be extracted to a separate
> function usb_check_attach, that is called just once at realize time,
> even if !s->cs->be_open.
>
> Please review, Thanks. :)
>
> Gonglei (2):
> usb-bus: introduce a wrapper function to check speed
> usb-serial: only check speed once at realize time
>
> hw/usb/bus.c | 14 +++++++++++++-
> hw/usb/dev-serial.c | 16 +++++++++-------
> include/hw/usb.h | 1 +
> 3 files changed, 23 insertions(+), 8 deletions(-)
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2014-09-19 8:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 7:25 [Qemu-devel] [PATCH 0/2] usb-serial: only check speed once at realize time arei.gonglei
2014-09-19 7:25 ` [Qemu-devel] [PATCH 1/2] usb-bus: introduce a wrapper function to check speed arei.gonglei
2014-09-19 7:25 ` [Qemu-devel] [PATCH 2/2] usb-serial: only check speed once at realize time arei.gonglei
2014-09-19 8:08 ` Paolo Bonzini [this message]
2014-09-19 8:12 ` [Qemu-devel] [PATCH 0/2] " Gonglei (Arei)
2014-09-23 10:59 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541BE462.70309@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=luonengjun@huawei.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.