Re: Alsa Driver Scarlett

[David Henningsson <david.henningsson@canonical.com>]

On 2014-09-18 18:20, Tobias Hoffmann wrote:
> On 18/09/14 14:29, David Henningsson wrote:
>> Hi Tobias,
>>
>> I believe you are the author of the repository at
>> https://github.com/smilingthax/alsa-driver_scarlett.
>
> Yes, I am.
>
>> Your Scarlett driver is reported to be working fine, and there are
>> some requests (see below) to get the driver into mainline Linux. Is
>> this something you would be interested in helping out with?
>
> I'm all for including the driver into mainline, but I do not have any time
> to go through N iterations of a patch to get it there.
>
> I *might* be able to do a initial cleaned up version against tiwai's
> for-next in the next few days, if that helps.
>
> Other than that, I will happily (try to) answer questions about the code.
>
>    Tobias

Ok, thanks for the update!

As I looked through the patches I noticed Robin Gareus (now cc:ed) were 
also the author of these patches, I assume you're okay with upstreaming 
it too, Robin?

There seem to be these "main" patches:

  * Initial code for 18i6 mixer (Robin)
  * Added log scale meters for 18i6 mixer (Robin)
  * Added code for 18i8 and "big rewrite" (Tobias)
  * Added code for 18i20 (Tobias)
  * Added code for 8i6 (Tobias)
  * Added code for 6i6 (Tobias)

...the rest of the patches are fixups which can be squashed into the 
existing patches when mainlining.

I could commit to do this squashing, run the remaining patches through 
checkpatch and submit the result on alsa-devel. I have no hw to test 
with though.

The big rewrite probably means that the rewrite patch should be squashed 
with the initial patch too, and list both of you as authors on the 
resulting patch. (Btw, what's the Linux kernel standard for that? To add 
a co-authored-by?)


>
>
>> Regards,
>>   David
>>
>> On 2014-09-16 16:10, Johannes Kroll wrote:
>>> On Tue, 16 Sep 2014 15:49:25 +0200
>>> Orm Finnendahl <orm.finnendahl@selma.hfmdk-frankfurt.de> wrote:
>>>
>>>> Am Dienstag, den 16. September 2014 um 15:22:27 Uhr (+0200) schrieb
>>>> Johannes Kroll:
>>>>>
>>>>> I guess I'll need to find the time to port the patch to a recent
>>>>> kernel
>>>>> when I upgrade, unless someone else does it first.
>>>>
>>>> The patch still works on our recent kernels (we are on debian testing
>>>> with a 3.14-2 kernel), atm there is no porting necessary. I can also
>>>> confirm that the driver has no known issues on our systems (we use a
>>>> couple of Scarlett 18i20 in different configurations). It would be
>>>> great, though if the patch could get integrated into alsa. At the
>>>> moment it is quite painful for our students with linux laptops as they
>>>> have to reapply the patch on every upgrade.
>>>
>>> Oh, I see. I'm all for integrating this patch into mainline. But I have
>>> never done such a thing, so I don't know how much effort it would be. I
>>> guess it would be a simple thing to do for a routine Alsa developer.
>>> Anyone? :]
>>> _______________________________________________
>>> Alsa-devel mailing list
>>> Alsa-devel@alsa-project.org
>>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>>
>>
>

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic