From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37112)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1XUuKH-0007xb-1R
	for qemu-devel@nongnu.org; Fri, 19 Sep 2014 05:18:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1XUuKA-00019o-Gz
	for qemu-devel@nongnu.org; Fri, 19 Sep 2014 05:18:00 -0400
Received: from mga01.intel.com ([192.55.52.88]:48387)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1XUuKA-000190-BE
	for qemu-devel@nongnu.org; Fri, 19 Sep 2014 05:17:54 -0400
Message-ID: <541BF4B9.9060708@intel.com>
Date: Fri, 19 Sep 2014 17:17:45 +0800
From: "Chen, Tiejun" <tiejun.chen@intel.com>
MIME-Version: 1.0
References: <1411116849-18157-1-git-send-email-pbonzini@redhat.com>
	<1411116849-18157-2-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1411116849-18157-2-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] serial: reset state at startup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, pavel.dovgaluk@ispras.ru, batuzovk@ispras.ru

On 2014/9/19 16:54, Paolo Bonzini wrote:
> When a serial port is started, its initial state is all zero.  Make
> it consistent with reset state instead.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hw/char/serial.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/serial.c b/hw/char/serial.c
> index 764e184..4523ccb 100644
> --- a/hw/char/serial.c
> +++ b/hw/char/serial.c
> @@ -668,6 +668,7 @@ void serial_realize_core(SerialState *s, Error **errp)
>                             serial_event, s);

It should just follow qemu_register_reset(serial_reset, s).

>       fifo8_create(&s->recv_fifo, UART_FIFO_LENGTH);
>       fifo8_create(&s->xmit_fifo, UART_FIFO_LENGTH);
> +    serial_reset(s);

Or at least we should push this before this pair of fifo8_create() since

static void serial_reset(void *opaque)
{
     ...
     fifo8_reset(&s->recv_fifo);
     fifo8_reset(&s->xmit_fifo);


Thanks
Tiejun

>   }
>
>   void serial_exit_core(SerialState *s)
>